Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

2015-08-13 Thread Andrew Morton
On Thu, 13 Aug 2015 09:55:25 +0900 Simon Horman wrote: > On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote: > > Transforming PFN(Page Frame Number) to struct page is never failure, so > > we can simplify the code logic to do the image->control_page assignment > > directly in the loop,

Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

2015-08-13 Thread Simon Horman
On Thu, Aug 13, 2015 at 01:53:45PM +0800, Baoquan He wrote: > On 08/13/15 at 09:55am, Simon Horman wrote: > > On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote: > > > Transforming PFN(Page Frame Number) to struct page is never failure, so > > > we can simplify the code logic to do the

Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

2015-08-13 Thread Simon Horman
On Thu, Aug 13, 2015 at 01:53:45PM +0800, Baoquan He wrote: On 08/13/15 at 09:55am, Simon Horman wrote: On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote: Transforming PFN(Page Frame Number) to struct page is never failure, so we can simplify the code logic to do the

Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

2015-08-13 Thread Andrew Morton
On Thu, 13 Aug 2015 09:55:25 +0900 Simon Horman ho...@verge.net.au wrote: On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote: Transforming PFN(Page Frame Number) to struct page is never failure, so we can simplify the code logic to do the image-control_page assignment directly in

Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

2015-08-12 Thread Baoquan He
On 08/13/15 at 09:55am, Simon Horman wrote: > On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote: > > Transforming PFN(Page Frame Number) to struct page is never failure, so > > we can simplify the code logic to do the image->control_page assignment > > directly in the loop, and remove

Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

2015-08-12 Thread Simon Horman
On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote: > Transforming PFN(Page Frame Number) to struct page is never failure, so > we can simplify the code logic to do the image->control_page assignment > directly in the loop, and remove the unnecessary conditional judgement. > >

Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

2015-08-12 Thread Baoquan He
On 08/13/15 at 09:55am, Simon Horman wrote: On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote: Transforming PFN(Page Frame Number) to struct page is never failure, so we can simplify the code logic to do the image-control_page assignment directly in the loop, and remove the

Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

2015-08-12 Thread Simon Horman
On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote: Transforming PFN(Page Frame Number) to struct page is never failure, so we can simplify the code logic to do the image-control_page assignment directly in the loop, and remove the unnecessary conditional judgement. Signed-off-by:

[REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

2015-07-27 Thread Minfei Huang
Transforming PFN(Page Frame Number) to struct page is never failure, so we can simplify the code logic to do the image->control_page assignment directly in the loop, and remove the unnecessary conditional judgement. Signed-off-by: Minfei Huang Acked-by: Dave Young Acked-by: Vivek Goyal ---

[REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

2015-07-27 Thread Minfei Huang
Transforming PFN(Page Frame Number) to struct page is never failure, so we can simplify the code logic to do the image-control_page assignment directly in the loop, and remove the unnecessary conditional judgement. Signed-off-by: Minfei Huang mnfhu...@gmail.com Acked-by: Dave Young