Re: [RESEND][PATCH] scsi: esas2r: fix potential format string flaw

2013-12-18 Thread Kees Cook
On Tue, Dec 17, 2013 at 9:42 PM, Joe Perches wrote: > On Tue, 2013-12-17 at 10:27 -0800, Kees Cook wrote: >> This makes sure format strings cannot leak into the printk call via the >> constructed buffer. > [] >> diff --git a/drivers/scsi/esas2r/esas2r_log.c >> b/drivers/scsi/esas2r/esas2r_log.c >

Re: [RESEND][PATCH] scsi: esas2r: fix potential format string flaw

2013-12-17 Thread Joe Perches
On Tue, 2013-12-17 at 10:27 -0800, Kees Cook wrote: > This makes sure format strings cannot leak into the printk call via the > constructed buffer. [] > diff --git a/drivers/scsi/esas2r/esas2r_log.c > b/drivers/scsi/esas2r/esas2r_log.c [] > @@ -171,7 +171,7 @@ static int esas2r_log_master(const lo

Re: [RESEND][PATCH] scsi: esas2r: fix potential format string flaw

2013-12-17 Thread Bradley Grove
Acked-by: Bradley Grove On 12/17/2013 01:27 PM, Kees Cook wrote: This makes sure format strings cannot leak into the printk call via the constructed buffer. Signed-off-by: Kees Cook --- drivers/scsi/esas2r/esas2r_log.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [RESEND][PATCH] scsi: esas2r: fix potential format string flaw

2013-12-17 Thread Greg Kroah-Hartman
On Tue, Dec 17, 2013 at 01:17:51PM -0800, Kees Cook wrote: > On Tue, Dec 17, 2013 at 12:00 PM, Greg Kroah-Hartman > wrote: > > On Tue, Dec 17, 2013 at 10:27:33AM -0800, Kees Cook wrote: > >> This makes sure format strings cannot leak into the printk call via the > >> constructed buffer. > >> > >>

Re: [RESEND][PATCH] scsi: esas2r: fix potential format string flaw

2013-12-17 Thread Kees Cook
On Tue, Dec 17, 2013 at 12:00 PM, Greg Kroah-Hartman wrote: > On Tue, Dec 17, 2013 at 10:27:33AM -0800, Kees Cook wrote: >> This makes sure format strings cannot leak into the printk call via the >> constructed buffer. >> >> Signed-off-by: Kees Cook >> --- >> drivers/scsi/esas2r/esas2r_log.c |

Re: [RESEND][PATCH] scsi: esas2r: fix potential format string flaw

2013-12-17 Thread Greg Kroah-Hartman
On Tue, Dec 17, 2013 at 10:27:33AM -0800, Kees Cook wrote: > This makes sure format strings cannot leak into the printk call via the > constructed buffer. > > Signed-off-by: Kees Cook > --- > drivers/scsi/esas2r/esas2r_log.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Why is this

[RESEND][PATCH] scsi: esas2r: fix potential format string flaw

2013-12-17 Thread Kees Cook
This makes sure format strings cannot leak into the printk call via the constructed buffer. Signed-off-by: Kees Cook --- drivers/scsi/esas2r/esas2r_log.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/esas2r/esas2r_log.c b/drivers/scsi/esas2r/esas2r_log.c ind