[RESEND] i2c: imx: defer probing on dma channel request

2019-03-25 Thread laurentiu . tudor
From: Laurentiu Tudor If the dma controller is not yet probed, defer i2c probe. The error path in probe was slightly modified (no functional change) to avoid triggering this WARN_ON(): "cg-pll0-div1 already disabled WARNING: CPU: 1 PID: 1 at drivers/clk/clk.c:828 clk_core_disable+0xa8/0xb0" Sign

Re: [RESEND] i2c: imx: defer probing on dma channel request

2019-03-26 Thread Peter Rosin
On 2019-03-25 18:12, Steven Price wrote: > On 25/03/2019 15:30, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor >> >> If the dma controller is not yet probed, defer i2c probe. >> The error path in probe was slightly modified (no functional change) *snip* >> @@ -1161,19 +1162,25 @@ static

Re: [RESEND] i2c: imx: defer probing on dma channel request

2019-03-26 Thread Laurentiu Tudor
Hi Steve, Thanks for the review! Few comments inline. On 25.03.2019 19:12, Steven Price wrote: > On 25/03/2019 15:30, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor >> >> If the dma controller is not yet probed, defer i2c probe. >> The error path in probe was slightly modified (no funct

Re: [RESEND] i2c: imx: defer probing on dma channel request

2019-03-27 Thread Laurentiu Tudor
Hello, Just FYI, I'm still seeing issues with the dma driver compiled _out_, trying to test i2c without dma support. I get the crash below in generic driver code later in the boot process, debug is in progress. P.S. This is seen on an NXP LS1043A chip. [5.152697] Unable to handle kernel NU

Re: [RESEND] i2c: imx: defer probing on dma channel request

2019-03-27 Thread Li Yang
On Wed, Mar 27, 2019 at 8:46 AM Laurentiu Tudor wrote: > > Hello, > > Just FYI, I'm still seeing issues with the dma driver compiled _out_, > trying to test i2c without dma support. I get the crash below in generic > driver code later in the boot process, debug is in progress. That probably means

RE: [RESEND] i2c: imx: defer probing on dma channel request

2019-03-28 Thread Aisheng Dong
> From: laurentiu.tu...@nxp.com [mailto:laurentiu.tu...@nxp.com] > Sent: Monday, March 25, 2019 11:30 PM > > From: Laurentiu Tudor > > If the dma controller is not yet probed, defer i2c probe. > The error path in probe was slightly modified (no functional change) to avoid > triggering this WARN_

Re: [RESEND] i2c: imx: defer probing on dma channel request

2019-03-28 Thread Laurentiu Tudor
Hi Leo, On 27.03.2019 20:47, Li Yang wrote: > On Wed, Mar 27, 2019 at 8:46 AM Laurentiu Tudor > wrote: >> >> Hello, >> >> Just FYI, I'm still seeing issues with the dma driver compiled _out_, >> trying to test i2c without dma support. I get the crash below in generic >> driver code later in the

Re: [RESEND] i2c: imx: defer probing on dma channel request

2019-03-25 Thread Steven Price
On 25/03/2019 15:30, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > If the dma controller is not yet probed, defer i2c probe. > The error path in probe was slightly modified (no functional change) There is a functional change for cases like: > ret = pm_runtime_get_sync(&pdev->

RE: [RESEND] i2c: imx: defer probing on dma channel request

2019-03-25 Thread Leo Li
...@pengutronix.de; > feste...@gmail.com; dl-linux-imx ; upstream- > rele...@linux.nxdi.nxp.com; Leo Li ; Laurentiu Tudor > > Subject: [RESEND] i2c: imx: defer probing on dma channel request > > From: Laurentiu Tudor > > If the dma controller is not yet probed, defer i2c pro