Re: [RESEND PATCH] fs/super.c set_anon_super calling optimization

2012-11-29 Thread Al Viro
On Fri, Nov 30, 2012 at 11:10:02AM +0530, Abhijit Pawar wrote: > > Because we want it to be a valid sget() callback. I doubt that this > > optimization is worth doing, though - might even micro-pessimize the things > > on architectures where all arguments are passed in registers. > > > Al, >

Re: [RESEND PATCH] fs/super.c set_anon_super calling optimization

2012-11-29 Thread Abhijit Pawar
On 11/30/2012 09:35 AM, Al Viro wrote: > On Fri, Oct 26, 2012 at 11:14:41AM -0200, Carlos Maiolino wrote: >> Hi, >> >> On Thu, Oct 25, 2012 at 05:08:19PM +0530, Abhijit Pawar wrote: >>> Hi, >>> set_anon_super is called by many filesystems. Some call directly and >>> some call through the wrapper. M

Re: [RESEND PATCH] fs/super.c set_anon_super calling optimization

2012-11-29 Thread Al Viro
On Fri, Oct 26, 2012 at 11:14:41AM -0200, Carlos Maiolino wrote: > Hi, > > On Thu, Oct 25, 2012 at 05:08:19PM +0530, Abhijit Pawar wrote: > > Hi, > > set_anon_super is called by many filesystems. Some call directly and > > some call through the wrapper. Many of them in the wrapper's call to > > th

Re: [RESEND PATCH] fs/super.c set_anon_super calling optimization

2012-10-26 Thread Abhijit Pawar
On 10/26/2012 06:44 PM, Carlos Maiolino wrote: Hi, On Thu, Oct 25, 2012 at 05:08:19PM +0530, Abhijit Pawar wrote: Hi, set_anon_super is called by many filesystems. Some call directly and some call through the wrapper. Many of them in the wrapper's call to this function are passing the second ar

Re: [RESEND PATCH] fs/super.c set_anon_super calling optimization

2012-10-26 Thread Carlos Maiolino
Hi, On Thu, Oct 25, 2012 at 05:08:19PM +0530, Abhijit Pawar wrote: > Hi, > set_anon_super is called by many filesystems. Some call directly and > some call through the wrapper. Many of them in the wrapper's call to > this function are passing the second argument to this function which > is not use

[RESEND PATCH] fs/super.c set_anon_super calling optimization

2012-10-25 Thread Abhijit Pawar
Hi, set_anon_super is called by many filesystems. Some call directly and some call through the wrapper. Many of them in the wrapper's call to this function are passing the second argument to this function which is not used anywhere. This patch replaces the second variable with NULL. Thanks,