From: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> Cppcheck complains about a possible null pointer dereference, but it's more like there is an unnecessary initialization before walking through a list.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovet...@linux.intel.com> Reviewed-by: Rander Wang <rander.w...@intel.com> Reviewed-by: Kai Vehmanen <kai.vehma...@linux.intel.com> Signed-off-by: Bard Liao <yung-chuan.l...@linux.intel.com> --- drivers/soundwire/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index a38b017f7a54..1a9e307e6a4c 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -593,7 +593,7 @@ EXPORT_SYMBOL(sdw_write); /* called with bus_lock held */ static struct sdw_slave *sdw_get_slave(struct sdw_bus *bus, int i) { - struct sdw_slave *slave = NULL; + struct sdw_slave *slave; list_for_each_entry(slave, &bus->slaves, node) { if (slave->dev_num == i) -- 2.17.1