Re: [RESEND PATCH 09/10] ide-floppy: use test_bit wrappers for testing flags

2008-01-05 Thread Bartlomiej Zolnierkiewicz
There are two issues here: * set_bit()/test_bit() are atomic operations and they don't see to be necessary in case of ide-floppy.c (standard '|'/'&' should be enough) * using wrappers for these operations is not a bad idea but doing it _now_ just makes it harder for us to figure out how to

Re: [RESEND PATCH 09/10] ide-floppy: use test_bit wrappers for testing flags

2008-01-05 Thread Bartlomiej Zolnierkiewicz
There are two issues here: * set_bit()/test_bit() are atomic operations and they don't see to be necessary in case of ide-floppy.c (standard '|'/'' should be enough) * using wrappers for these operations is not a bad idea but doing it _now_ just makes it harder for us to figure out how to

[RESEND PATCH 09/10] ide-floppy: use test_bit wrappers for testing flags

2008-01-03 Thread Borislav Petkov
also, fix header comments and remove superfluous ones. There should be no functionality change resulting from this patch. Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> --- drivers/ide/ide-floppy.c | 45 - drivers/ide/ide-floppy.h | 127

[RESEND PATCH 09/10] ide-floppy: use test_bit wrappers for testing flags

2008-01-03 Thread Borislav Petkov
also, fix header comments and remove superfluous ones. There should be no functionality change resulting from this patch. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-floppy.c | 45 - drivers/ide/ide-floppy.h | 127