Re: [RESEND PATCH 1/2] perf, cpu hotplug: Run CPU_STARTING notifiers with irqs disabled

2012-10-16 Thread Srivatsa S. Bhat
On 10/17/2012 12:04 AM, Paul E. McKenney wrote: > On Tue, Oct 16, 2012 at 10:07:15PM +0530, Srivatsa S. Bhat wrote: >> On 10/16/2012 10:01 PM, Paul E. McKenney wrote: >>> On Tue, Oct 16, 2012 at 01:28:10PM +0530, Srivatsa S. Bhat wrote: The CPU_STARTING notifiers are supposed to be run with ir

Re: [RESEND PATCH 1/2] perf, cpu hotplug: Run CPU_STARTING notifiers with irqs disabled

2012-10-16 Thread Paul E. McKenney
On Tue, Oct 16, 2012 at 10:07:15PM +0530, Srivatsa S. Bhat wrote: > On 10/16/2012 10:01 PM, Paul E. McKenney wrote: > > On Tue, Oct 16, 2012 at 01:28:10PM +0530, Srivatsa S. Bhat wrote: > >> The CPU_STARTING notifiers are supposed to be run with irqs disabled. But > >> the > >> perf_cpu_notifier()

Re: [RESEND PATCH 1/2] perf, cpu hotplug: Run CPU_STARTING notifiers with irqs disabled

2012-10-16 Thread Paul E. McKenney
On Tue, Oct 16, 2012 at 01:28:10PM +0530, Srivatsa S. Bhat wrote: > The CPU_STARTING notifiers are supposed to be run with irqs disabled. But the > perf_cpu_notifier() macro invokes them without doing that. Fix it. Color me confused... Isn't perf_event_task_tick() invoked only from scheduler_tick

Re: [RESEND PATCH 1/2] perf, cpu hotplug: Run CPU_STARTING notifiers with irqs disabled

2012-10-16 Thread Srivatsa S. Bhat
On 10/16/2012 10:01 PM, Paul E. McKenney wrote: > On Tue, Oct 16, 2012 at 01:28:10PM +0530, Srivatsa S. Bhat wrote: >> The CPU_STARTING notifiers are supposed to be run with irqs disabled. But the >> perf_cpu_notifier() macro invokes them without doing that. Fix it. > > Color me confused... Hehe,

[RESEND PATCH 1/2] perf, cpu hotplug: Run CPU_STARTING notifiers with irqs disabled

2012-10-16 Thread Srivatsa S. Bhat
The CPU_STARTING notifiers are supposed to be run with irqs disabled. But the perf_cpu_notifier() macro invokes them without doing that. Fix it. Signed-off-by: Srivatsa S. Bhat --- include/linux/perf_event.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/perf_event.h b/