Re: [RESEND PATCH 2/7] time: Change posix clocks ops interfaces to use timespec64

2017-03-21 Thread Thomas Gleixner
On Tue, 21 Mar 2017, Arnd Bergmann wrote: > On Mon, Mar 20, 2017 at 9:40 PM, Thomas Gleixner wrote: > > On Mon, 20 Mar 2017, Deepa Dinamani wrote: > >> >> -static int ptp_clock_getres(struct posix_clock *pc, struct timespec > >> >> *tp) > >> >> +static int ptp_clock_getres(struct posix_clock *pc

Re: [RESEND PATCH 2/7] time: Change posix clocks ops interfaces to use timespec64

2017-03-21 Thread Arnd Bergmann
On Mon, Mar 20, 2017 at 9:40 PM, Thomas Gleixner wrote: > On Mon, 20 Mar 2017, Deepa Dinamani wrote: >> >> -static int ptp_clock_getres(struct posix_clock *pc, struct timespec *tp) >> >> +static int ptp_clock_getres(struct posix_clock *pc, struct timespec64 >> >> *tp) >> > >> > That's a pretty po

Re: [Y2038] [RESEND PATCH 2/7] time: Change posix clocks ops interfaces to use timespec64

2017-03-20 Thread Tomoyoshi ASANO
On Sun, 19 Mar 2017 11:51:34 +0100 (CET) Thomas Gleixner wrote: > On Sat, 18 Mar 2017, Deepa Dinamani wrote: > > > struct timespec is not y2038 safe. > > Replace the posix_clock ops interfaces to use > > struct timespec64. > > The patch also changes struct itimerspec interfaces to > > stru

Re: [RESEND PATCH 2/7] time: Change posix clocks ops interfaces to use timespec64

2017-03-20 Thread Thomas Gleixner
On Mon, 20 Mar 2017, Deepa Dinamani wrote: > >> -static int ptp_clock_getres(struct posix_clock *pc, struct timespec *tp) > >> +static int ptp_clock_getres(struct posix_clock *pc, struct timespec64 *tp) > > > > That's a pretty pointless exercise. getres() returns the resolution of the > > clock whi

Re: [RESEND PATCH 2/7] time: Change posix clocks ops interfaces to use timespec64

2017-03-20 Thread Deepa Dinamani
> Please do not explain WHAT the patch is doing. We can see that from the > diff itself. What's important is the WHY. A good changelog is structured in > paragraphs, which explain the context, the problem and the solution. Please > read Documentation/process/submitting-patches.rst. Let me give you

Re: [RESEND PATCH 2/7] time: Change posix clocks ops interfaces to use timespec64

2017-03-20 Thread Deepa Dinamani
> When changing the PTP code, please put the PTP maintainer onto CC. Will do. Thanks for pointing out the omission. -Deepa

Re: [RESEND PATCH 2/7] time: Change posix clocks ops interfaces to use timespec64

2017-03-19 Thread Richard Cochran
On Sat, Mar 18, 2017 at 10:17:41PM -0700, Deepa Dinamani wrote: > struct timespec is not y2038 safe. > Replace the posix_clock ops interfaces to use > struct timespec64. > The patch also changes struct itimerspec interfaces to > struct itimerspec64 as itimerspec internally uses timespec > and

Re: [RESEND PATCH 2/7] time: Change posix clocks ops interfaces to use timespec64

2017-03-19 Thread Thomas Gleixner
On Sat, 18 Mar 2017, Deepa Dinamani wrote: > struct timespec is not y2038 safe. > Replace the posix_clock ops interfaces to use > struct timespec64. > The patch also changes struct itimerspec interfaces to > struct itimerspec64 as itimerspec internally uses timespec > and itimerspec64 uses t

[RESEND PATCH 2/7] time: Change posix clocks ops interfaces to use timespec64

2017-03-18 Thread Deepa Dinamani
struct timespec is not y2038 safe. Replace the posix_clock ops interfaces to use struct timespec64. The patch also changes struct itimerspec interfaces to struct itimerspec64 as itimerspec internally uses timespec and itimerspec64 uses timespec64. PTP clocks is the only module that sets up t