RE: [RESEND PATCH V13 3/3] Input: new da7280 haptic driver

2020-06-24 Thread Roy Im
On Thu, June 25, 2020 1:28 AM, Uwe Kleine-König > On Wed, Jun 24, 2020 at 03:39:52PM +, Roy Im wrote: > > On Wed, Jun 24, 2020 at 10:37 PM, Uwe Kleine-König wrote: > > > On Wed, Jun 24, 2020 at 12:04:24PM +0900, Roy Im wrote: > > > > period2freq = 100 / state.period; > > > >

Re: [RESEND PATCH V13 3/3] Input: new da7280 haptic driver

2020-06-24 Thread Uwe Kleine-König
Hello, On Wed, Jun 24, 2020 at 03:39:52PM +, Roy Im wrote: > On Wed, Jun 24, 2020 at 10:37 PM, Uwe Kleine-König wrote: > > On Wed, Jun 24, 2020 at 12:04:24PM +0900, Roy Im wrote: > > > period2freq = 100 / state.period; > > > if (period2freq < DA7280_MIN_PWM_FREQ_KHZ ||

RE: [RESEND PATCH V13 3/3] Input: new da7280 haptic driver

2020-06-24 Thread Roy Im
On Wed, Jun 24, 2020 at 10:37 PM, Uwe Kleine-König wrote: > On Wed, Jun 24, 2020 at 12:04:24PM +0900, Roy Im wrote: > > Hello Uwe, > > > > On Tue, June 23, 2020 11:41 PM, Uwe Kleine-König wrote: > > > > > > Hello, > > > > > > On Mon, Jun 15, 2020 at 08:40:23PM +0900, Roy Im wrote: > > > > Adds supp

Re: [RESEND PATCH V13 3/3] Input: new da7280 haptic driver

2020-06-24 Thread Uwe Kleine-König
On Wed, Jun 24, 2020 at 12:04:24PM +, Roy Im wrote: > Hello Uwe, > > On Tue, June 23, 2020 11:41 PM, Uwe Kleine-König wrote: > > > > Hello, > > > > On Mon, Jun 15, 2020 at 08:40:23PM +0900, Roy Im wrote: > > > Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with multiple > > > mode

RE: [RESEND PATCH V13 3/3] Input: new da7280 haptic driver

2020-06-24 Thread Roy Im
Hello Uwe, On Tue, June 23, 2020 11:41 PM, Uwe Kleine-König wrote: > > Hello, > > On Mon, Jun 15, 2020 at 08:40:23PM +0900, Roy Im wrote: > > Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with multiple > > mode and integrated waveform memory and wideband support. > > It communicates v

Re: [RESEND PATCH V13 3/3] Input: new da7280 haptic driver

2020-06-23 Thread Uwe Kleine-König
Hello, On Mon, Jun 15, 2020 at 08:40:23PM +0900, Roy Im wrote: > Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with > multiple mode and integrated waveform memory and wideband support. > It communicates via an I2C bus to the device. > > Signed-off-by: Roy Im Just some picky comments

[RESEND PATCH V13 3/3] Input: new da7280 haptic driver

2020-06-15 Thread Roy Im
Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with multiple mode and integrated waveform memory and wideband support. It communicates via an I2C bus to the device. Signed-off-by: Roy Im --- v13: - Updated some conditions in pwm function and alignments. v12: No changes. v11:

[RESEND PATCH V13 3/3] Input: new da7280 haptic driver

2020-05-21 Thread Roy Im
Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with multiple mode and integrated waveform memory and wideband support. It communicates via an I2C bus to the device. Signed-off-by: Roy Im --- v13: - Updated some conditions in pwm function and alignments. v12: No changes. v11: