Re: [RESEND PATCH v1] proc: use untagged_addr() for pagemap_read addresses

2020-11-26 Thread Miles Chen
On Thu, 2020-11-26 at 11:10 +, Catalin Marinas wrote: > Hi Miles, > > Could you please cc me and Andrey Konovalov on future versions of this > patch (if any)? > > On Mon, 23 Nov 2020 at 08:47, Miles Chen wrote: > > When we try to visit the pagemap of a tagged userspace pointer, we find > >

Re: [RESEND PATCH v1] proc: use untagged_addr() for pagemap_read addresses

2020-11-26 Thread Miles Chen
On Tue, 2020-11-24 at 12:32 -0600, Eric W. Biederman wrote: > Miles Chen writes: > > > When we try to visit the pagemap of a tagged userspace pointer, we find > > that the start_vaddr is not correct because of the tag. > > To fix it, we should untag the usespace pointers in pagemap_read(). > > >

Re: [RESEND PATCH v1] proc: use untagged_addr() for pagemap_read addresses

2020-11-26 Thread Catalin Marinas
Hi Miles, Could you please cc me and Andrey Konovalov on future versions of this patch (if any)? On Mon, 23 Nov 2020 at 08:47, Miles Chen wrote: > When we try to visit the pagemap of a tagged userspace pointer, we find > that the start_vaddr is not correct because of the tag. > To fix it, we

RE: [RESEND PATCH v1] proc: use untagged_addr() for pagemap_read addresses

2020-11-26 Thread Song Bao Hua (Barry Song)
sd_upstr...@mediatek.com > Subject: RE: [RESEND PATCH v1] proc: use untagged_addr() for pagemap_read > addresses > > > > > -Original Message- > > From: Miles Chen [mailto:miles.c...@mediatek.com] > > Sent: Thursday, November 26, 2020 8:49 PM > >

RE: [RESEND PATCH v1] proc: use untagged_addr() for pagemap_read addresses

2020-11-25 Thread Song Bao Hua (Barry Song)
rnel.org; linux-media...@lists.infradead.org; > wsd_upstr...@mediatek.com > Subject: RE: [RESEND PATCH v1] proc: use untagged_addr() for pagemap_read > addresses > > On Thu, 2020-11-26 at 07:16 +, Song Bao Hua (Barry Song) wrote: > > > > > -Original Message- > > >

RE: [RESEND PATCH v1] proc: use untagged_addr() for pagemap_read addresses

2020-11-25 Thread Miles Chen
inux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; > > linux-media...@lists.infradead.org; wsd_upstr...@mediatek.com; Miles > > Chen > > Subject: [RESEND PATCH v1] proc: use untagged_addr() for pagemap_read > > addresses > > > > When we try to visit

RE: [RESEND PATCH v1] proc: use untagged_addr() for pagemap_read addresses

2020-11-25 Thread Song Bao Hua (Barry Song)
upstr...@mediatek.com; Miles > Chen > Subject: [RESEND PATCH v1] proc: use untagged_addr() for pagemap_read > addresses > > When we try to visit the pagemap of a tagged userspace pointer, we find > that the start_vaddr is not correct because of the tag. > To fix it, we should u

Re: [RESEND PATCH v1] proc: use untagged_addr() for pagemap_read addresses

2020-11-24 Thread Eric W. Biederman
Miles Chen writes: > When we try to visit the pagemap of a tagged userspace pointer, we find > that the start_vaddr is not correct because of the tag. > To fix it, we should untag the usespace pointers in pagemap_read(). > > I tested with 5.10-rc4 and the issue remains. > > My test code is baed

[RESEND PATCH v1] proc: use untagged_addr() for pagemap_read addresses

2020-11-22 Thread Miles Chen
When we try to visit the pagemap of a tagged userspace pointer, we find that the start_vaddr is not correct because of the tag. To fix it, we should untag the usespace pointers in pagemap_read(). I tested with 5.10-rc4 and the issue remains. My test code is baed on [1]: A userspace pointer