Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-28 Thread Michael Turquette
Quoting Doug Anderson (2015-08-28 14:08:52) > Mike, > > On Fri, Aug 28, 2015 at 1:02 PM, Michael Turquette > wrote: > > Hi Doug, > > > > Quoting Doug Anderson (2015-08-27 19:03:20) > >> Kevin, > >> > >> On Thu, Aug 27, 2015 at 5:24 PM, Kevin Hilman wrote: > >> >> That is not really workable: the

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-28 Thread Kevin Hilman
Michael Turquette writes: > Hi Doug, > > Quoting Doug Anderson (2015-08-27 19:03:20) >> Kevin, >> >> On Thu, Aug 27, 2015 at 5:24 PM, Kevin Hilman wrote: >> >> That is not really workable: the attach and detach happen in >> >> probe/remove path; if you do not have driver for the device you will

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-28 Thread Doug Anderson
Mike, On Fri, Aug 28, 2015 at 1:02 PM, Michael Turquette wrote: > Hi Doug, > > Quoting Doug Anderson (2015-08-27 19:03:20) >> Kevin, >> >> On Thu, Aug 27, 2015 at 5:24 PM, Kevin Hilman wrote: >> >> That is not really workable: the attach and detach happen in >> >> probe/remove path; if you do no

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-28 Thread Michael Turquette
Hi Doug, Quoting Doug Anderson (2015-08-27 19:03:20) > Kevin, > > On Thu, Aug 27, 2015 at 5:24 PM, Kevin Hilman wrote: > >> That is not really workable: the attach and detach happen in > >> probe/remove path; if you do not have driver for the device you will > >> miss the clocks for it. > > > >

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-27 Thread Doug Anderson
Kevin, On Thu, Aug 27, 2015 at 5:24 PM, Kevin Hilman wrote: >> That is not really workable: the attach and detach happen in >> probe/remove path; if you do not have driver for the device you will >> miss the clocks for it. > > And in my proposal, I suggested that clocks without drivers are > good

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-27 Thread Kevin Hilman
Dmitry Torokhov writes: > On Tue, Aug 25, 2015 at 3:45 PM, Kevin Hilman wrote: >> Doug Anderson writes: >> >>> To put things in a >>> concrete way, for pd_vio we'd go through the entire device tree >>> ourselves and find all properties that look like "power-domains = >>> <&power RK3288_PD_VIO>;

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-26 Thread Caesar Wang
在 2015年08月26日 06:45, Kevin Hilman 写道: Doug Anderson writes: Kevin, On Tue, Aug 25, 2015 at 2:07 PM, Kevin Hilman wrote: Caesar Wang writes: We can add more domains node in the future. This patch add the needed clocks into power-controller. As the discuess about all the device clocks be

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-25 Thread Doug Anderson
Kevin, On Tue, Aug 25, 2015 at 3:45 PM, Kevin Hilman wrote: >> To put things in a >> concrete way, for pd_vio we'd go through the entire device tree >> ourselves and find all properties that look like "power-domains = >> <&power RK3288_PD_VIO>;". We'd then find the parent of those >> properties

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-25 Thread Dmitry Torokhov
On Tue, Aug 25, 2015 at 3:45 PM, Kevin Hilman wrote: > Doug Anderson writes: > >> To put things in a >> concrete way, for pd_vio we'd go through the entire device tree >> ourselves and find all properties that look like "power-domains = >> <&power RK3288_PD_VIO>;". We'd then find the parent of t

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-25 Thread Kevin Hilman
Doug Anderson writes: > Kevin, > > On Tue, Aug 25, 2015 at 2:07 PM, Kevin Hilman wrote: >> Caesar Wang writes: >> >>> We can add more domains node in the future. >>> This patch add the needed clocks into power-controller. >>> As the discuess about all the device clocks being listed in >>> the p

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-25 Thread Doug Anderson
Kevin, On Tue, Aug 25, 2015 at 2:07 PM, Kevin Hilman wrote: > Caesar Wang writes: > >> We can add more domains node in the future. >> This patch add the needed clocks into power-controller. >> As the discuess about all the device clocks being listed in >> the power-domains itself. >> >> There ar

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-25 Thread Kevin Hilman
Caesar Wang writes: > We can add more domains node in the future. > This patch add the needed clocks into power-controller. > As the discuess about all the device clocks being listed in > the power-domains itself. > > There are several reasons as follows: > > Firstly, the clocks need be turned of

[RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

2015-08-25 Thread Caesar Wang
We can add more domains node in the future. This patch add the needed clocks into power-controller. As the discuess about all the device clocks being listed in the power-domains itself. There are several reasons as follows: Firstly, the clocks need be turned off to save power when the system ente