Re: [RESEND PATCH v2] devres: Really align data field to unsigned long long

2018-07-09 Thread Geert Uytterhoeven
On Mon, Jul 9, 2018 at 7:49 AM Greg KH wrote: > On Mon, Jul 09, 2018 at 07:44:44AM +0300, Alexey Brodkin wrote: > > Depending on ABI "long long" type of a particular 32-bit CPU > > might be aligned by either word (32-bits) or double word (64-bits). Or even 16-bit (on e.g. m68k). > > --- a/driver

Re: [RESEND PATCH v2] devres: Really align data field to unsigned long long

2018-07-08 Thread Greg KH
On Mon, Jul 09, 2018 at 07:44:44AM +0300, Alexey Brodkin wrote: > Depending on ABI "long long" type of a particular 32-bit CPU > might be aligned by either word (32-bits) or double word (64-bits). > Make sure "data" is really 64-bit aligned for any 32-bit CPU. > > At least for 32-bit ARC cores ABI

[RESEND PATCH v2] devres: Really align data field to unsigned long long

2018-07-08 Thread Alexey Brodkin
Depending on ABI "long long" type of a particular 32-bit CPU might be aligned by either word (32-bits) or double word (64-bits). Make sure "data" is really 64-bit aligned for any 32-bit CPU. At least for 32-bit ARC cores ABI requires "long long" types to be aligned by normal 32-bit word. This make