Re: [RESEND PATCH v2] dt-bindings: net: correct interrupt flags in examples

2020-11-28 Thread Jakub Kicinski
On Fri, 27 Nov 2020 20:35:55 +0100 Marc Kleine-Budde wrote: > On 11/27/20 5:27 PM, Jakub Kicinski wrote: > > On Fri, 27 Nov 2020 10:13:01 +0100 Marc Kleine-Budde wrote: > >> On 10/26/20 4:36 PM, Krzysztof Kozlowski wrote: > >>> GPIO_ACTIVE_x flags are not correct in the context of interrupt

Re: [RESEND PATCH v2] dt-bindings: net: correct interrupt flags in examples

2020-11-28 Thread Marc Kleine-Budde
On 11/27/20 5:27 PM, Jakub Kicinski wrote: > On Fri, 27 Nov 2020 10:13:01 +0100 Marc Kleine-Budde wrote: >> On 10/26/20 4:36 PM, Krzysztof Kozlowski wrote: >>> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. >>> These are simple defines so they could be used in DTS but they

Re: [RESEND PATCH v2] dt-bindings: net: correct interrupt flags in examples

2020-11-27 Thread Jakub Kicinski
On Fri, 27 Nov 2020 10:13:01 +0100 Marc Kleine-Budde wrote: > On 10/26/20 4:36 PM, Krzysztof Kozlowski wrote: > > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > > These are simple defines so they could be used in DTS but they will not > > have the same meaning: > > 1.

Re: [RESEND PATCH v2] dt-bindings: net: correct interrupt flags in examples

2020-11-27 Thread Marc Kleine-Budde
On 10/26/20 4:36 PM, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2. GPIO_ACTIVE_LOW = 1 =

[RESEND PATCH v2] dt-bindings: net: correct interrupt flags in examples

2020-10-26 Thread Krzysztof Kozlowski
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING Correct the interrupt flags, assuming the