On Thu, Jan 04, 2018 at 01:44:30PM +, Srinivas Kandagatla wrote:
> Initially I had this in pcm driver, but looking at example usage of
> snd_dma_alloc_pages, most of them use card->dev and some of them use pcm
> device for allocating dma memory.
If they're using card->dev for DMA they're mess
On 04/01/18 12:02, Mark Brown wrote:
On Wed, Jan 03, 2018 at 09:20:45AM -0800, Stephen Boyd wrote:
On 12/14/2017 09:34 AM, srinivas.kandaga...@linaro.org wrote:
uThis patch adds support to DB820c machine driver.
+ ret = dma_coerce_mask_and_coherent(card->dev, DMA_BIT_MASK(32));
On Wed, Jan 03, 2018 at 09:20:45AM -0800, Stephen Boyd wrote:
> On 12/14/2017 09:34 AM, srinivas.kandaga...@linaro.org wrote:
> > uThis patch adds support to DB820c machine driver.
> > + ret = dma_coerce_mask_and_coherent(card->dev, DMA_BIT_MASK(32));
> Why do we need to do this? Can you add s
On 03/01/18 19:41, Stephen Boyd wrote:
+ ret = dma_coerce_mask_and_coherent(card->dev, DMA_BIT_MASK(32));
Why do we need to do this? Can you add some sort of comment in the code
about why?
Even though dsp supports 64 bit addresses, but the sid sits at
offset of 32, which brings this res
On Wed 03 Jan 08:27 PST 2018, Srinivas Kandagatla wrote:
> Thanks for the review comments.
>
>
> On 03/01/18 00:16, Bjorn Andersson wrote:
> > On Thu 14 Dec 09:34 PST 2017, srinivas.kandaga...@linaro.org wrote:
> >
> > > From: Srinivas Kandagatla
> > >
> > > uThis patch adds support to DB820c
On 01/03, Srinivas Kandagatla wrote:
> Thanks for your review comments,
>
> On 03/01/18 17:20, Stephen Boyd wrote:
> >>+
> >>+ return ret;
> >>+}
> >>+
> >>+static int msm_snd_apq8096_probe(struct platform_device *pdev)
> >>+{
> >>+ int ret;
> >>+ struct snd_soc_card *card;
> >>+
> >>+ car
Thanks for your review comments,
On 03/01/18 17:20, Stephen Boyd wrote:
On 12/14/2017 09:34 AM, srinivas.kandaga...@linaro.org wrote:
From: Srinivas Kandagatla
diff --git a/sound/soc/qcom/apq8096.c b/sound/soc/qcom/apq8096.c
new file mode 100644
index ..5b2036317f71
--- /dev/nu
On 12/14/2017 09:34 AM, srinivas.kandaga...@linaro.org wrote:
> From: Srinivas Kandagatla
>
> uThis patch adds support to DB820c machine driver.
>
> Signed-off-by: Srinivas Kandagatla
> ---
> sound/soc/qcom/Kconfig | 9 +++-
> sound/soc/qcom/apq8096.c | 124
> +++
Thanks for the review comments.
On 03/01/18 00:16, Bjorn Andersson wrote:
On Thu 14 Dec 09:34 PST 2017, srinivas.kandaga...@linaro.org wrote:
From: Srinivas Kandagatla
uThis patch adds support to DB820c machine driver.
Drop 'u' and expand the message to claim that this is the machine driv
On Thu 14 Dec 09:34 PST 2017, srinivas.kandaga...@linaro.org wrote:
> From: Srinivas Kandagatla
>
> uThis patch adds support to DB820c machine driver.
Drop 'u' and expand the message to claim that this is the machine driver
for 8996, used by the db820c.
[..]
> +static struct snd_soc_dai_link m
From: Srinivas Kandagatla
uThis patch adds support to DB820c machine driver.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/Kconfig | 9 +++-
sound/soc/qcom/apq8096.c | 124 +++
2 files changed, 132 insertions(+), 1 deletion(-)
create mod
11 matches
Mail list logo
