Re: [RESEND PATCH v2 6/6] mmc: sdhci-bcm-kona: Add basic use of clocks

2013-10-21 Thread Tim Kryger
On Thu, Oct 17, 2013 at 7:13 AM, Mark Rutland wrote: > On Wed, Oct 16, 2013 at 10:47:10PM +0100, Tim Kryger wrote: >> Enable the external clock needed by the host controller during the >> probe and disable it during the remove. > > This requires a biding document update. The current best

Re: [RESEND PATCH v2 6/6] mmc: sdhci-bcm-kona: Add basic use of clocks

2013-10-21 Thread Tim Kryger
On Thu, Oct 17, 2013 at 7:13 AM, Mark Rutland mark.rutl...@arm.com wrote: On Wed, Oct 16, 2013 at 10:47:10PM +0100, Tim Kryger wrote: Enable the external clock needed by the host controller during the probe and disable it during the remove. This requires a biding document update. The current

Re: [RESEND PATCH v2 6/6] mmc: sdhci-bcm-kona: Add basic use of clocks

2013-10-18 Thread Matt Porter
On Thu, Oct 17, 2013 at 03:13:09PM +0100, Mark Rutland wrote: > On Wed, Oct 16, 2013 at 10:47:10PM +0100, Tim Kryger wrote: > > + /* Get and enable the external clock */ > > + kona_dev->external_clk = devm_clk_get(dev, NULL); > > + if (IS_ERR(kona_dev->external_clk)) { > > +

Re: [RESEND PATCH v2 6/6] mmc: sdhci-bcm-kona: Add basic use of clocks

2013-10-18 Thread Matt Porter
On Thu, Oct 17, 2013 at 03:13:09PM +0100, Mark Rutland wrote: On Wed, Oct 16, 2013 at 10:47:10PM +0100, Tim Kryger wrote: + /* Get and enable the external clock */ + kona_dev-external_clk = devm_clk_get(dev, NULL); + if (IS_ERR(kona_dev-external_clk)) { + dev_err(dev,

Re: [RESEND PATCH v2 6/6] mmc: sdhci-bcm-kona: Add basic use of clocks

2013-10-17 Thread Mark Rutland
On Wed, Oct 16, 2013 at 10:47:10PM +0100, Tim Kryger wrote: > Enable the external clock needed by the host controller during the > probe and disable it during the remove. This requires a biding document update. I note that the binding is already incomplete (it does not describe the interrupts or

Re: [RESEND PATCH v2 6/6] mmc: sdhci-bcm-kona: Add basic use of clocks

2013-10-17 Thread Mark Rutland
On Wed, Oct 16, 2013 at 10:47:10PM +0100, Tim Kryger wrote: Enable the external clock needed by the host controller during the probe and disable it during the remove. This requires a biding document update. I note that the binding is already incomplete (it does not describe the interrupts or

[RESEND PATCH v2 6/6] mmc: sdhci-bcm-kona: Add basic use of clocks

2013-10-16 Thread Tim Kryger
Enable the external clock needed by the host controller during the probe and disable it during the remove. Signed-off-by: Tim Kryger Reviewed-by: Markus Mayer Reviewed-by: Matt Porter --- drivers/mmc/host/sdhci-bcm-kona.c | 30 -- 1 file changed, 28 insertions(+),

[RESEND PATCH v2 6/6] mmc: sdhci-bcm-kona: Add basic use of clocks

2013-10-16 Thread Tim Kryger
Enable the external clock needed by the host controller during the probe and disable it during the remove. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org Reviewed-by: Matt Porter matt.por...@linaro.org --- drivers/mmc/host/sdhci-bcm-kona.c | 30