Re: [RESEND PATCH v4 2/3] usb: serial: xr_serial: Add gpiochip support

2020-08-06 Thread Johan Hovold
On Sun, Jul 26, 2020 at 09:22:23PM +0530, Manivannan Sadhasivam wrote: > On Wed, Jul 01, 2020 at 03:02:06PM +0200, Johan Hovold wrote: > > On Sun, Jun 07, 2020 at 09:53:49PM +0530, Manivannan Sadhasivam wrote: > > > Add gpiochip support for Maxlinear/Exar USB to serial converter > > > for

Re: [RESEND PATCH v4 2/3] usb: serial: xr_serial: Add gpiochip support

2020-07-27 Thread Andy Shevchenko
On Mon, Jul 27, 2020 at 7:46 AM Manivannan Sadhasivam wrote: > On Sun, Jul 26, 2020 at 07:34:54PM +0300, Andy Shevchenko wrote: > > On Sun, Jul 26, 2020 at 6:53 PM Manivannan Sadhasivam > > wrote: ... > > I'm wondering if you may use mctrl_gpio_*() API instead. > > How? mctrl_gpio APIs are a

Re: [RESEND PATCH v4 2/3] usb: serial: xr_serial: Add gpiochip support

2020-07-26 Thread Manivannan Sadhasivam
On Sun, Jul 26, 2020 at 07:34:54PM +0300, Andy Shevchenko wrote: > On Sun, Jul 26, 2020 at 6:53 PM Manivannan Sadhasivam wrote: > > On Wed, Jul 01, 2020 at 03:02:06PM +0200, Johan Hovold wrote: > > > On Sun, Jun 07, 2020 at 09:53:49PM +0530, Manivannan Sadhasivam wrote: > > ... > > > > Same

Re: [RESEND PATCH v4 2/3] usb: serial: xr_serial: Add gpiochip support

2020-07-26 Thread Andy Shevchenko
On Sun, Jul 26, 2020 at 6:53 PM Manivannan Sadhasivam wrote: > On Wed, Jul 01, 2020 at 03:02:06PM +0200, Johan Hovold wrote: > > On Sun, Jun 07, 2020 at 09:53:49PM +0530, Manivannan Sadhasivam wrote: ... > > Same here. And perhaps just ignoring the pins managed by gpiolib is > > better (cf.

Re: [RESEND PATCH v4 2/3] usb: serial: xr_serial: Add gpiochip support

2020-07-26 Thread Manivannan Sadhasivam
On Wed, Jul 01, 2020 at 03:02:06PM +0200, Johan Hovold wrote: > On Sun, Jun 07, 2020 at 09:53:49PM +0530, Manivannan Sadhasivam wrote: > > Add gpiochip support for Maxlinear/Exar USB to serial converter > > for controlling the available gpios. > > > > Inspired from cp210x usb to serial converter

Re: [RESEND PATCH v4 2/3] usb: serial: xr_serial: Add gpiochip support

2020-07-01 Thread Johan Hovold
On Sun, Jun 07, 2020 at 09:53:49PM +0530, Manivannan Sadhasivam wrote: > Add gpiochip support for Maxlinear/Exar USB to serial converter > for controlling the available gpios. > > Inspired from cp210x usb to serial converter driver. > > Cc: Linus Walleij > Cc: linux-g...@vger.kernel.org >

[RESEND PATCH v4 2/3] usb: serial: xr_serial: Add gpiochip support

2020-06-07 Thread Manivannan Sadhasivam
Add gpiochip support for Maxlinear/Exar USB to serial converter for controlling the available gpios. Inspired from cp210x usb to serial converter driver. Cc: Linus Walleij Cc: linux-g...@vger.kernel.org Reviewed-by: Linus Walleij Signed-off-by: Manivannan Sadhasivam ---