Re: [RESEND PATCH v4 3/3] mmc: sdhci-of-arasan: add runtime pm support

2015-12-15 Thread Ulf Hansson
Hi Shawn, Sorry for the delay. [...] >> >> I think your are in right track, but unfortunate you still have some >> work to do. :-) >> >> You can't call sdhci_suspend_host() with a runtime suspended host. You >> will for example access sdhci internal registers, even-though the >> clock to the SDH

Re: [RESEND PATCH v4 3/3] mmc: sdhci-of-arasan: add runtime pm support

2015-10-22 Thread Shawn Lin
On 2015/10/22 20:08, Ulf Hansson wrote: On 22 October 2015 at 11:06, Shawn Lin wrote: This patch add runtime_suspend and runtime_resume for sdhci-of-arasan. Currently we also power-off phy at runtime_suspend for power-saving. Signed-off-by: Shawn Lin Serise-changes: 4 - remove ifdef for PM c

Re: [RESEND PATCH v4 3/3] mmc: sdhci-of-arasan: add runtime pm support

2015-10-22 Thread Ulf Hansson
On 22 October 2015 at 11:06, Shawn Lin wrote: > This patch add runtime_suspend and runtime_resume for > sdhci-of-arasan. Currently we also power-off phy at > runtime_suspend for power-saving. > > Signed-off-by: Shawn Lin > > Serise-changes: 4 > - remove ifdef for PM callback statement > - fix mis

Re: [RESEND PATCH v4 3/3] mmc: sdhci-of-arasan: add runtime pm support

2015-10-22 Thread Shawn Lin
On 2015/10/22 17:44, Michal Simek wrote: On 10/22/2015 11:06 AM, Shawn Lin wrote: This patch add runtime_suspend and runtime_resume for sdhci-of-arasan. Currently we also power-off phy at runtime_suspend for power-saving. Signed-off-by: Shawn Lin Serise-changes: 4 - remove ifdef for PM callba

Re: [RESEND PATCH v4 3/3] mmc: sdhci-of-arasan: add runtime pm support

2015-10-22 Thread Michal Simek
On 10/22/2015 11:06 AM, Shawn Lin wrote: > This patch add runtime_suspend and runtime_resume for > sdhci-of-arasan. Currently we also power-off phy at > runtime_suspend for power-saving. > > Signed-off-by: Shawn Lin > > Serise-changes: 4 > - remove ifdef for PM callback statement > - fix missing

[RESEND PATCH v4 3/3] mmc: sdhci-of-arasan: add runtime pm support

2015-10-22 Thread Shawn Lin
This patch add runtime_suspend and runtime_resume for sdhci-of-arasan. Currently we also power-off phy at runtime_suspend for power-saving. Signed-off-by: Shawn Lin Serise-changes: 4 - remove ifdef for PM callback statement - fix missing pm_runtime_set_active - remove pm_runtime_dont_use_autosus