Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-04 Thread Lee Jones
On Tue, 04 Nov 2014, Mark Brown wrote: > On Tue, Nov 04, 2014 at 09:16:09AM +, Lee Jones wrote: > > On Tue, 04 Nov 2014, Paul Bolle wrote: > > > > Nothing will break. But I think Mark prefers the dependency rename, now > > > done in 7/8, to be done as part of this patch. > > > I don't

Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-04 Thread Mark Brown
On Tue, Nov 04, 2014 at 09:16:09AM +, Lee Jones wrote: > On Tue, 04 Nov 2014, Paul Bolle wrote: > > Nothing will break. But I think Mark prefers the dependency rename, now > > done in 7/8, to be done as part of this patch. > I don't agree. The rename should be taken independantly by Mark. >

Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-04 Thread Lee Jones
On Mon, 03 Nov 2014, Lee Jones wrote: > On Fri, 31 Oct 2014, gyun...@gmail.com wrote: > > > From: Gyungoh Yoo > > > > Signed-off-by: Gyungoh Yoo > > --- > > Changes v6: > > Added new line character at the end of line of dev_err() > > > > Changes v5: > > Move sky81452-backlight.h to

Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-04 Thread Lee Jones
On Fri, 31 Oct 2014, gyun...@gmail.com wrote: > From: Gyungoh Yoo > > Signed-off-by: Gyungoh Yoo > --- > Changes v6: > Added new line character at the end of line of dev_err() > > Changes v5: > Move sky81452-backlight.h to include/linux/platform_data > > Changes v4: > Removed

Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-04 Thread Lee Jones
On Tue, 04 Nov 2014, Paul Bolle wrote: > On Mon, 2014-11-03 at 22:30 +, Lee Jones wrote: > > On Mon, 03 Nov 2014, Paul Bolle wrote: > > > > > On Mon, 2014-11-03 at 17:14 +, Lee Jones wrote: > > > That patch makes REGULATOR_SKY81452 depend on MFD_SKY81452, > > > making it buildable. > >

Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-04 Thread Paul Bolle
On Mon, 2014-11-03 at 22:30 +, Lee Jones wrote: > On Mon, 03 Nov 2014, Paul Bolle wrote: > > > On Mon, 2014-11-03 at 17:14 +, Lee Jones wrote: > > That patch makes REGULATOR_SKY81452 depend on MFD_SKY81452, > > making it buildable. > > Okay, so I can take this patch with no fall-out

Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-04 Thread Paul Bolle
On Mon, 2014-11-03 at 22:30 +, Lee Jones wrote: On Mon, 03 Nov 2014, Paul Bolle wrote: On Mon, 2014-11-03 at 17:14 +, Lee Jones wrote: That patch makes REGULATOR_SKY81452 depend on MFD_SKY81452, making it buildable. Okay, so I can take this patch with no fall-out then. Nothing

Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-04 Thread Lee Jones
On Tue, 04 Nov 2014, Paul Bolle wrote: On Mon, 2014-11-03 at 22:30 +, Lee Jones wrote: On Mon, 03 Nov 2014, Paul Bolle wrote: On Mon, 2014-11-03 at 17:14 +, Lee Jones wrote: That patch makes REGULATOR_SKY81452 depend on MFD_SKY81452, making it buildable. Okay, so I can

Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-04 Thread Lee Jones
On Fri, 31 Oct 2014, gyun...@gmail.com wrote: From: Gyungoh Yoo jack@skyworksinc.com Signed-off-by: Gyungoh Yoo jack@skyworksinc.com --- Changes v6: Added new line character at the end of line of dev_err() Changes v5: Move sky81452-backlight.h to include/linux/platform_data

Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-04 Thread Lee Jones
On Mon, 03 Nov 2014, Lee Jones wrote: On Fri, 31 Oct 2014, gyun...@gmail.com wrote: From: Gyungoh Yoo jack@skyworksinc.com Signed-off-by: Gyungoh Yoo jack@skyworksinc.com --- Changes v6: Added new line character at the end of line of dev_err() Changes v5: Move

Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-04 Thread Mark Brown
On Tue, Nov 04, 2014 at 09:16:09AM +, Lee Jones wrote: On Tue, 04 Nov 2014, Paul Bolle wrote: Nothing will break. But I think Mark prefers the dependency rename, now done in 7/8, to be done as part of this patch. I don't agree. The rename should be taken independantly by Mark. The

Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-04 Thread Lee Jones
On Tue, 04 Nov 2014, Mark Brown wrote: On Tue, Nov 04, 2014 at 09:16:09AM +, Lee Jones wrote: On Tue, 04 Nov 2014, Paul Bolle wrote: Nothing will break. But I think Mark prefers the dependency rename, now done in 7/8, to be done as part of this patch. I don't agree. The rename

Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-03 Thread Lee Jones
On Mon, 03 Nov 2014, Paul Bolle wrote: > On Mon, 2014-11-03 at 17:14 +, Lee Jones wrote: > >On Fri, 31 Oct 2014, gyun...@gmail.com wrote: > > Code looks fine, but what are its dependencies. I'm assuming nothing; > > however, did Mark say that something depends on it? > > That would be

Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-03 Thread Paul Bolle
On Mon, 2014-11-03 at 17:14 +, Lee Jones wrote: >On Fri, 31 Oct 2014, gyun...@gmail.com wrote: > Code looks fine, but what are its dependencies. I'm assuming nothing; > however, did Mark say that something depends on it? That would be REGULATOR_SKY81452. That is currently dangling (since

Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-03 Thread Lee Jones
On Fri, 31 Oct 2014, gyun...@gmail.com wrote: > From: Gyungoh Yoo > > Signed-off-by: Gyungoh Yoo > --- > Changes v6: > Added new line character at the end of line of dev_err() > > Changes v5: > Move sky81452-backlight.h to include/linux/platform_data > > Changes v4: > Removed

Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-03 Thread Lee Jones
On Fri, 31 Oct 2014, gyun...@gmail.com wrote: From: Gyungoh Yoo jack@skyworksinc.com Signed-off-by: Gyungoh Yoo jack@skyworksinc.com --- Changes v6: Added new line character at the end of line of dev_err() Changes v5: Move sky81452-backlight.h to include/linux/platform_data

Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-03 Thread Paul Bolle
On Mon, 2014-11-03 at 17:14 +, Lee Jones wrote: On Fri, 31 Oct 2014, gyun...@gmail.com wrote: Code looks fine, but what are its dependencies. I'm assuming nothing; however, did Mark say that something depends on it? That would be REGULATOR_SKY81452. That is currently dangling (since

Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-11-03 Thread Lee Jones
On Mon, 03 Nov 2014, Paul Bolle wrote: On Mon, 2014-11-03 at 17:14 +, Lee Jones wrote: On Fri, 31 Oct 2014, gyun...@gmail.com wrote: Code looks fine, but what are its dependencies. I'm assuming nothing; however, did Mark say that something depends on it? That would be

[RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-10-31 Thread gyungoh
From: Gyungoh Yoo Signed-off-by: Gyungoh Yoo --- Changes v6: Added new line character at the end of line of dev_err() Changes v5: Move sky81452-backlight.h to include/linux/platform_data Changes v4: Removed MODULE_VERSION() Modified license to GPLv2 Changes v3: Fixed the backlight name from

[RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

2014-10-31 Thread gyungoh
From: Gyungoh Yoo jack@skyworksinc.com Signed-off-by: Gyungoh Yoo jack@skyworksinc.com --- Changes v6: Added new line character at the end of line of dev_err() Changes v5: Move sky81452-backlight.h to include/linux/platform_data Changes v4: Removed MODULE_VERSION() Modified license to