Re: [REVIEW][PATCH 03/20] signal/x86: Move MCE error reporting out of force_sig_info_fault

2018-09-19 Thread Eric W. Biederman
Thomas Gleixner writes: > On Tue, 18 Sep 2018, Eric W. Biederman wrote: >> #ifdef CONFIG_MEMORY_FAILURE >> if (fault & (VM_FAULT_HWPOISON|VM_FAULT_HWPOISON_LARGE)) { >> +unsigned lsb = 0; > > Newline between variable declaration and code please. > >> printk(KERN_ERR

Re: [REVIEW][PATCH 03/20] signal/x86: Move MCE error reporting out of force_sig_info_fault

2018-09-18 Thread Thomas Gleixner
On Tue, 18 Sep 2018, Eric W. Biederman wrote: > #ifdef CONFIG_MEMORY_FAILURE > if (fault & (VM_FAULT_HWPOISON|VM_FAULT_HWPOISON_LARGE)) { > + unsigned lsb = 0; Newline between variable declaration and code please. > printk(KERN_ERR > "MCE: Killing %s:%d due

[REVIEW][PATCH 03/20] signal/x86: Move MCE error reporting out of force_sig_info_fault

2018-09-17 Thread Eric W. Biederman
Only the call from do_sigbus will send SIGBUS due to a memory machine check error. Consolidate all of the machine check signal generation code in do_sigbus and remove the now unnecessary fault parameter from force_sig_info_fault. Explicitly use the now constant si_code BUS_ADRERR in the call to f