Re: [REVIEW][PATCH 2/4] proc: Implement /proc/thread-self to point at the directory of the current thread

2014-08-06 Thread Serge Hallyn
Quoting Eric W. Biederman (ebied...@xmission.com): > > Hi Eric, > > > > I've not had a chance to test these, but apart from two trivial > > comments below these look good to me, and I appreciate the feature. > > So with the two fixes (if needed), > > > > Acked-by: Serge Hallyn > > >> +static int

Re: [REVIEW][PATCH 2/4] proc: Implement /proc/thread-self to point at the directory of the current thread

2014-08-06 Thread Eric W. Biederman
> Hi Eric, > > I've not had a chance to test these, but apart from two trivial > comments below these look good to me, and I appreciate the feature. > So with the two fixes (if needed), > > Acked-by: Serge Hallyn >> +static int proc_thread_self_readlink(struct dentry *dentry, char __user >> *buf

Re: [REVIEW][PATCH 2/4] proc: Implement /proc/thread-self to point at the directory of the current thread

2014-08-06 Thread Serge E. Hallyn
Quoting Eric W. Biederman (ebied...@xmission.com): > > /proc/thread-self is derived from /proc/self. /proc/thread-self > points to the directory in proc containing information about the > current thread. > > This funtionality has been missing for a long time, and is tricky to > implement in user

[REVIEW][PATCH 2/4] proc: Implement /proc/thread-self to point at the directory of the current thread

2014-07-31 Thread Eric W. Biederman
/proc/thread-self is derived from /proc/self. /proc/thread-self points to the directory in proc containing information about the current thread. This funtionality has been missing for a long time, and is tricky to implement in userspace as gettid() is not exported by glibc. More importantly thi