Re: [RFC, PATCH, take 2] watchdog on generic gpio

2008-01-14 Thread Haavard Skinnemoen
On Mon, 14 Jan 2008 15:03:14 +0100 Florian Fainelli <[EMAIL PROTECTED]> wrote: > Le lundi 14 janvier 2008, Marc Pignat a écrit : > > Hi Florian! > > I understand your wish, but... > > You told me that your plaform doesn't implement the generic gpio > > interface (yet?), so this driver can't work f

Re: [RFC, PATCH, take 2] watchdog on generic gpio

2008-01-14 Thread Marc Pignat
On Monday 14 January 2008, Florian Fainelli wrote: > Le lundi 14 janvier 2008, Marc Pignat a écrit : > > Hi Florian! > > I understand your wish, but... > > You told me that your plaform doesn't implement the generic gpio interface > > (yet?), so this driver can't work for you. > > You understood m

Re: [RFC, PATCH, take 2] watchdog on generic gpio

2008-01-14 Thread Florian Fainelli
Le lundi 14 janvier 2008, Marc Pignat a écrit : > Hi Florian! > I understand your wish, but... > You told me that your plaform doesn't implement the generic gpio interface > (yet?), so this driver can't work for you. You understood me wrong, I told you that not all platforms, actually only AVR32

Re: [RFC, PATCH, take 2] watchdog on generic gpio

2008-01-14 Thread Marc Pignat
Hi Florian! On Monday 14 January 2008, Florian Fainelli wrote: ... > I would like this function to be supplied by the platform_data structure > because as I mentioned before, not all GPIO connected watchdog will simply > need a single bit to be toggled, but also sometimes a full GPIO line. I und

Re: [RFC, PATCH, take 2] watchdog on generic gpio

2008-01-14 Thread Florian Fainelli
Hi Marc, Le lundi 14 janvier 2008, Marc Pignat a écrit : > +static int gpio_wdt_keepalive(struct gpio_wdt *wdt) > +{ > + gpio_set_value(wdt->pdata->pin, 0); > + gpio_set_value(wdt->pdata->pin, 1); > + return 0; > +} I would like this function to be supplied by the platform_data struct

[RFC, PATCH, take 2] watchdog on generic gpio

2008-01-14 Thread Marc Pignat
watchdog driver for embedded systems with a supervisor watchdog (MAX823 or so) connected to a gpio. This is the platform_driver and needs platform_data for defining the gpio pin and the watchdog timeout. Signed-off-by: Marc Pignat <[EMAIL PROTECTED]> --- Hi! Changes form take1: * corrected incl