Re: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver

2018-02-07 Thread Rafael J. Wysocki
018 3:55 AM > > > To: Rafael J. Wysocki > > > Cc: Andy Shevchenko ; Limonciello, Mario > > > ; andriy.shevche...@linux.intel.com; > > > dvh...@infradead.org; platform-driver-...@vger.kernel.org; > > > acelan@canonical.com; linux-kernel@vger.kernel.

Re: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver

2018-02-07 Thread Rafael J. Wysocki
On Wednesday, February 7, 2018 10:55:22 AM CET Pali Rohár wrote: > On Wednesday 07 February 2018 10:47:57 Rafael J. Wysocki wrote: > > BTW, please CC patches with ACPI material to linux-acpi. They are less > > likely > > to be overlooked by me then and the others on that list may have opinions on

Re: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver

2018-02-07 Thread Andy Shevchenko
lo, Mario > > ; andriy.shevche...@linux.intel.com; > > dvh...@infradead.org; platform-driver-...@vger.kernel.org; > > acelan@canonical.com; linux-kernel@vger.kernel.org > > Subject: Re: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to > > pure ACPI driver > >

RE: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver

2018-02-07 Thread Mario.Limonciello
.kernel.org; > acelan@canonical.com; linux-kernel@vger.kernel.org > Subject: Re: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI > driver > > On Wednesday 07 February 2018 10:47:57 Rafael J. Wysocki wrote: > > BTW, please CC patches with ACPI material to lin

Re: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver

2018-02-07 Thread Pali Rohár
On Wednesday 07 February 2018 10:47:57 Rafael J. Wysocki wrote: > BTW, please CC patches with ACPI material to linux-acpi. They are less likely > to be overlooked by me then and the others on that list may have opinions on > them too. Maybe we can update MAINTAINERS file for acpi based platform-x

Re: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver

2018-02-07 Thread Rafael J. Wysocki
> > > Sent: Monday, February 5, 2018 10:18 AM > > > > To: Darren Hart > > > > Cc: platform-driver-...@vger.kernel.org; AceLan Kao > > > > ; linux-kernel@vger.kernel.org; > > > > pali.ro...@gmail.com; Limonciello, Mario ; > > > Rafael

Re: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver

2018-02-07 Thread Rafael J. Wysocki
On Wednesday, January 31, 2018 10:37:26 PM CET Darren Hart wrote: > On Wed, Jan 31, 2018 at 08:26:14PM +0200, Andy Shevchenko wrote: > > Remove code duplication by converting driver to pure ACPI one. > > +Rafael > > I don't see any reason *not* to do this, it seems the acpi driver model > provid

Re: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver

2018-02-07 Thread Rafael J. Wysocki
...@vger.kernel.org; AceLan Kao > > > ; linux-kernel@vger.kernel.org; > > > pali.ro...@gmail.com; Limonciello, Mario ; > > Rafael > > > Wysocki > > > Subject: Re: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure > > ACPI driver > > > > >

RE: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver

2018-02-06 Thread Mario.Limonciello
>Yeah, that's fixed in the branch. >P.S. Apologies for top-posting, wrote from phone in order to not waste time Andy, I tested your review branch on XPS 9365 which uses power button through intel-vbtn. I confirmed it worked properly both with usage in OS and during S2I. Thanks,

RE: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver

2018-02-06 Thread Mario.Limonciello
o > ; linux-kernel@vger.kernel.org; > pali.ro...@gmail.com; Limonciello, Mario ; Rafael > Wysocki > Subject: Re: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI > driver > > On Wed, 2018-01-31 at 13:37 -0800, Darren Hart wrote: > > On Wed, Jan 31, 20

Re: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver

2018-02-05 Thread Andy Shevchenko
On Wed, 2018-01-31 at 13:37 -0800, Darren Hart wrote: > On Wed, Jan 31, 2018 at 08:26:14PM +0200, Andy Shevchenko wrote: > > Remove code duplication by converting driver to pure ACPI one. > I have fixed couple issues, but... > +Rafael > > I don't see any reason *not* to do this, it seems the ac

Re: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver

2018-01-31 Thread Darren Hart
On Wed, Jan 31, 2018 at 08:26:14PM +0200, Andy Shevchenko wrote: > Remove code duplication by converting driver to pure ACPI one. +Rafael I don't see any reason *not* to do this, it seems the acpi driver model provides some of the boilerplate stuff we were doing manually before as a platform devi

[RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver

2018-01-31 Thread Andy Shevchenko
Remove code duplication by converting driver to pure ACPI one. Signed-off-by: Andy Shevchenko --- - not tested drivers/platform/x86/intel-vbtn.c | 93 +-- 1 file changed, 22 insertions(+), 71 deletions(-) diff --git a/drivers/platform/x86/intel-vbtn.c b/driv