Re: [RFC,PATCH] efi: Add support for a UEFI variable filesystem

2012-09-02 Thread Matthew Garrett
On Sun, Sep 02, 2012 at 06:59:37PM -0700, H. Peter Anvin wrote: > Well, appending is an action, not really a property of the variable that > sticks around, no? We could do this for append, but what happens if an attribute with similar variables appears and doesn't neatly map to an O_ option? We

Re: [RFC,PATCH] efi: Add support for a UEFI variable filesystem

2012-09-02 Thread Jeremy Kerr
Hi hpa, > Well, appending is an action, not really a property of the variable > that sticks around, no? True, but they're still all defined as the same thing in the UEFI spec. If you're looking to define which attributes to pass, you now need to know the extra information that you pass most of th

Re: [RFC,PATCH] efi: Add support for a UEFI variable filesystem

2012-09-02 Thread H. Peter Anvin
Well, appending is an action, not really a property of the variable that sticks around, no? Jeremy Kerr wrote: >hi hpa, > >> Wouldn't that be better handled by O_APPEND? > >Possibly, but this then means that there are now two "interfaces" that >specify the variable attributes. > >[Also, in that

Re: [RFC,PATCH] efi: Add support for a UEFI variable filesystem

2012-09-02 Thread Jeremy Kerr
hi hpa, > Wouldn't that be better handled by O_APPEND? Possibly, but this then means that there are now two "interfaces" that specify the variable attributes. [Also, in that case we should support the same mechanism through open(); llseek(0, SEEK_END) then, right?] In general, I think the attri

Re: [RFC,PATCH] efi: Add support for a UEFI variable filesystem

2012-08-30 Thread H. Peter Anvin
Wouldn't that be better handled by O_APPEND? Jeremy Kerr wrote: >Hi hpa, > >Thanks for the review! > >> However, I have a question... rather than putting the attributes as >the >> first data bytes, would it be better to make it either part of the >> filename (assuming there is at least one cha

Re: [RFC,PATCH] efi: Add support for a UEFI variable filesystem

2012-08-30 Thread Jeremy Kerr
Hi hpa, Thanks for the review! However, I have a question... rather than putting the attributes as the first data bytes, would it be better to make it either part of the filename (assuming there is at least one character other than / which can be reasonably relied upon to not be part of the nam

Re: [RFC,PATCH] efi: Add support for a UEFI variable filesystem

2012-08-30 Thread H. Peter Anvin
On 08/30/2012 02:30 AM, Jeremy Kerr wrote: > From: Matthew Garrett > > The existing EFI variables code only supports variables of up to 1024 > bytes. This limitation existed in version 0.99 of the EFI specification, > but was removed before any full releases. Since variables can now be > larger t