Re: [RFC/PATCH] Update coding standard to avoid ungrepable printk format strings

2008-02-24 Thread Andy Whitcroft
On Fri, Feb 22, 2008 at 02:26:12PM +0100, Andi Kleen wrote: > At some point checkpatch.pl would need to be updated to know about this > exception too, that would be the next step. Cirtainly we have exceptions for docstrings, so that shouldn't be a problem if this were accepted. -apw -- To unsubs

Re: [RFC/PATCH] Update coding standard to avoid ungrepable printk format strings

2008-02-24 Thread Andy Whitcroft
On Sat, Feb 23, 2008 at 01:55:32PM +0100, Christer Weinigel wrote: > Andi Kleen wrote: > >RFC: Update coding standard to avoid split up printk format strings > > While we're talking about checkpatch.pl, I'd definitely like to teach > checkpatch about "list_for_each" and friends. > > list_for_eac

Re: [RFC/PATCH] Update coding standard to avoid ungrepable printk format strings

2008-02-23 Thread Christer Weinigel
Andi Kleen wrote: RFC: Update coding standard to avoid split up printk format strings While we're talking about checkpatch.pl, I'd definitely like to teach checkpatch about "list_for_each" and friends. list_for_each is flow control, not a function call. I find it much easier to see that so

Re: [RFC/PATCH] Update coding standard to avoid ungrepable printk format strings

2008-02-22 Thread Joe Perches
On Fri, 2008-02-22 at 14:26 +0100, Andi Kleen wrote: > RFC: Update coding standard to avoid split up printk format strings Perhaps it's more useful to have git become more content aware. If git could track user specified file glob pattern ("*.[ch]$") changes by statement terminator (";") and git

Re: [RFC/PATCH] Update coding standard to avoid ungrepable printk format strings

2008-02-22 Thread Alan Cox
> At some point checkpatch.pl would need to be updated to know about this > exception too, that would be the next step. > > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [RFC/PATCH] Update coding standard to avoid ungrepable printk format strings

2008-02-22 Thread Andi Kleen
> Instead of a new recommendation (from now on we recommend something > contrary to what we required up until yesterday --- let's go unwrap > strings everywhere in the kernel now), how about simply saying that > printk format strings are not subject to the 80 column rule? I personally slightly pre

Re: [RFC/PATCH] Update coding standard to avoid ungrepable printk format strings

2008-02-22 Thread Stefan Richter
Andi Kleen wrote: > --- linux.orig/Documentation/CodingStyle > +++ linux/Documentation/CodingStyle > @@ -83,20 +83,32 @@ preferred limit. > Statements longer than 80 columns will be broken into sensible chunks. > Descendants are always substantially shorter than the parent and are placed > subst

[RFC/PATCH] Update coding standard to avoid ungrepable printk format strings

2008-02-22 Thread Andi Kleen
RFC: Update coding standard to avoid split up printk format strings Common occurrence: You see some error message in the kernel log you don't understand, Standard way to handle this is to grep the kernel source code for that error message and then look at the code and figure out what is wrong fro