Re: [RFC/PATCH]reconfigure MSI registers after resume

2005-09-02 Thread Andrew Morton
Rajesh Shah <[EMAIL PROTECTED]> wrote: > > On Thu, Sep 01, 2005 at 01:59:32PM -0700, Nguyen, Tom L wrote: > > On Thursday, September 01, 2005 1:10 PM Andrew Morton wrote: > > > Is it not possible to do this in some single centralized place? > > Existing pci_save_state(dev)/pci_restore_state(dev) co

Re: [RFC/PATCH]reconfigure MSI registers after resume

2005-09-02 Thread Rajesh Shah
On Thu, Sep 01, 2005 at 01:59:32PM -0700, Nguyen, Tom L wrote: > On Thursday, September 01, 2005 1:10 PM Andrew Morton wrote: > > Is it not possible to do this in some single centralized place? > Existing pci_save_state(dev)/pci_restore_state(dev) covers only 64 bytes > of PCI header. One solution

RE: [RFC/PATCH]reconfigure MSI registers after resume

2005-09-02 Thread Nguyen, Tom L
On Thursday, September 01, 2005 10:38 PM Greg KH wrote: >> Existing pci_save_state(dev)/pci_restore_state(dev) covers only 64 bytes >> of PCI header. One solution is to extend these APIs to cover up to 256 >> bytes. What do you think? > Will that solve this issue? Yes. Thanks, Tom - To unsubscrib

Re: [RFC/PATCH]reconfigure MSI registers after resume

2005-09-01 Thread Greg KH
On Thu, Sep 01, 2005 at 01:59:32PM -0700, Nguyen, Tom L wrote: > On Thursday, September 01, 2005 1:10 PM Andrew Morton wrote: > >> > >> On Thursday, September 01, 2005 12:32 PM Andrew Morton wrote: > >> > So what is the alternative to Shaohua's fix? Restore all the msi > >> > registers on resume?

RE: [RFC/PATCH]reconfigure MSI registers after resume

2005-09-01 Thread Shaohua Li
On Thu, 2005-09-01 at 23:20 +0800, Nguyen, Tom L wrote: > On Wednesday, August 31, 2005 2:44 PM Greg KH wrote: > >>On Thu, Aug 18, 2005 at 01:35:46PM +0800, Shaohua Li wrote: > >> Hi, > >> It appears pci_enable_msi doesn't reconfigure msi registers if it > >> successfully look up a msi for a device

RE: [RFC/PATCH]reconfigure MSI registers after resume

2005-09-01 Thread Nguyen, Tom L
On Thursday, September 01, 2005 1:10 PM Andrew Morton wrote: >> >> On Thursday, September 01, 2005 12:32 PM Andrew Morton wrote: >> > So what is the alternative to Shaohua's fix? Restore all the msi >> > registers on resume? >> >> Yes, the PCIe port bus driver, for example, did that. >> > So y

Re: [RFC/PATCH]reconfigure MSI registers after resume

2005-09-01 Thread Andrew Morton
"Nguyen, Tom L" <[EMAIL PROTECTED]> wrote: > > On Wednesday, August 31, 2005 2:44 PM Greg KH wrote: > >>On Thu, Aug 18, 2005 at 01:35:46PM +0800, Shaohua Li wrote: > >> Hi, > >> It appears pci_enable_msi doesn't reconfigure msi registers if it > >> successfully look up a msi for a device. It assume

RE: [RFC/PATCH]reconfigure MSI registers after resume

2005-09-01 Thread Nguyen, Tom L
On Thursday, September 01, 2005 12:32 PM Andrew Morton wrote: > So what is the alternative to Shaohua's fix? Restore all the msi > registers on resume? Yes, the PCIe port bus driver, for example, did that. Thanks, Tom - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [RFC/PATCH]reconfigure MSI registers after resume

2005-09-01 Thread Andrew Morton
"Nguyen, Tom L" <[EMAIL PROTECTED]> wrote: > > On Thursday, September 01, 2005 12:32 PM Andrew Morton wrote: > > So what is the alternative to Shaohua's fix? Restore all the msi > > registers on resume? > > Yes, the PCIe port bus driver, for example, did that. > So you're saying that each indi

RE: [RFC/PATCH]reconfigure MSI registers after resume

2005-09-01 Thread Nguyen, Tom L
On Wednesday, August 31, 2005 2:44 PM Greg KH wrote: >>On Thu, Aug 18, 2005 at 01:35:46PM +0800, Shaohua Li wrote: >> Hi, >> It appears pci_enable_msi doesn't reconfigure msi registers if it >> successfully look up a msi for a device. It assumes the data and address >> registers unchanged after cal

Re: [RFC/PATCH]reconfigure MSI registers after resume

2005-08-31 Thread Greg KH
On Thu, Aug 18, 2005 at 01:35:46PM +0800, Shaohua Li wrote: > Hi, > It appears pci_enable_msi doesn't reconfigure msi registers if it > successfully look up a msi for a device. It assumes the data and address > registers unchanged after calling pci_disable_msi. But this isn't always > true, such as

[RFC/PATCH]reconfigure MSI registers after resume

2005-08-17 Thread Shaohua Li
Hi, It appears pci_enable_msi doesn't reconfigure msi registers if it successfully look up a msi for a device. It assumes the data and address registers unchanged after calling pci_disable_msi. But this isn't always true, such as in a suspend/resume circle. In my test system, the registers unsurpri