Re: [RFC/PATCH 0/2] perf tools: Factor sort elide

2014-05-29 Thread Namhyung Kim
On Fri, 23 May 2014 17:15:45 +0200, Jiri Olsa wrote: > hi, > factoring the elide code to make perf_hpp__should_skip > function cheap call/check again. Both look good to me! Acked-by: Namhyung Kim > > Also I was wondering.. do we want to get rid of sort_entry > structs in favor of perf_hpp__*

Re: [RFC/PATCH 0/2] perf tools: Factor sort elide

2014-05-29 Thread Namhyung Kim
On Fri, 23 May 2014 17:15:45 +0200, Jiri Olsa wrote: hi, factoring the elide code to make perf_hpp__should_skip function cheap call/check again. Both look good to me! Acked-by: Namhyung Kim namhy...@kernel.org Also I was wondering.. do we want to get rid of sort_entry structs in favor of

[RFC/PATCH 0/2] perf tools: Factor sort elide

2014-05-23 Thread Jiri Olsa
hi, factoring the elide code to make perf_hpp__should_skip function cheap call/check again. Also I was wondering.. do we want to get rid of sort_entry structs in favor of perf_hpp__* stuff? Any plans? I'm sending this a RFC, since any other such refactoring would change this stuff for sure as

[RFC/PATCH 0/2] perf tools: Factor sort elide

2014-05-23 Thread Jiri Olsa
hi, factoring the elide code to make perf_hpp__should_skip function cheap call/check again. Also I was wondering.. do we want to get rid of sort_entry structs in favor of perf_hpp__* stuff? Any plans? I'm sending this a RFC, since any other such refactoring would change this stuff for sure as