Re: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

2013-02-21 Thread Kevin Hilman
Frederic Weisbecker writes: > 2013/2/21 Frederic Weisbecker : >> 2013/2/21 Kevin Hilman : >>> Subject: [PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors >>> >>> Use the atomic64_* accessors for all the kernel_cpustat fields to >>> ensure atomic access on non-64 bit platforms. >>>

Re: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

2013-02-21 Thread Frederic Weisbecker
2013/2/21 Russell King - ARM Linux : > On Thu, Feb 21, 2013 at 10:53:07PM +0100, Frederic Weisbecker wrote: >> That too should be kcpustat_this_cpu_set(), or kcpustat_this_cpu_add() >> FWIW. But we probably don't need the overhead of atomic_add() that >> does a LOCK. >> atomic_set(var,

Re: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

2013-02-21 Thread Russell King - ARM Linux
On Thu, Feb 21, 2013 at 10:53:07PM +0100, Frederic Weisbecker wrote: > That too should be kcpustat_this_cpu_set(), or kcpustat_this_cpu_add() > FWIW. But we probably don't need the overhead of atomic_add() that > does a LOCK. > atomic_set(var, atomic_read(var) + delta) would be better. All we need

Re: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

2013-02-21 Thread Frederic Weisbecker
2013/2/21 Frederic Weisbecker : > 2013/2/21 Kevin Hilman : >> Subject: [PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors >> >> Use the atomic64_* accessors for all the kernel_cpustat fields to >> ensure atomic access on non-64 bit platforms. >> >> Thanks to Mats Liljegren for

Re: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

2013-02-21 Thread Frederic Weisbecker
2013/2/21 Kevin Hilman : > Subject: [PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors > > Use the atomic64_* accessors for all the kernel_cpustat fields to > ensure atomic access on non-64 bit platforms. > > Thanks to Mats Liljegren for CGROUP_CPUACCT related fixes. > > Cc: Mats

Re: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

2013-02-21 Thread Kevin Hilman
Kevin Hilman writes: > Use the atomic64_* accessors for all the kernel_cpustat fields to > ensure atomic access on non-64 bit platforms. > > Thanks to Mats Liljegren for CGROUP_CPUACCT related fixes. > > Cc: Mats Liljegren > Signed-off-by: Kevin Hilman The kbuild test bot reported some build

Re: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

2013-02-21 Thread Kevin Hilman
Kevin Hilman khil...@linaro.org writes: Use the atomic64_* accessors for all the kernel_cpustat fields to ensure atomic access on non-64 bit platforms. Thanks to Mats Liljegren for CGROUP_CPUACCT related fixes. Cc: Mats Liljegren mats.liljeg...@enea.com Signed-off-by: Kevin Hilman

Re: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

2013-02-21 Thread Frederic Weisbecker
2013/2/21 Kevin Hilman khil...@linaro.org: Subject: [PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors Use the atomic64_* accessors for all the kernel_cpustat fields to ensure atomic access on non-64 bit platforms. Thanks to Mats Liljegren for CGROUP_CPUACCT related fixes. Cc:

Re: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

2013-02-21 Thread Frederic Weisbecker
2013/2/21 Frederic Weisbecker fweis...@gmail.com: 2013/2/21 Kevin Hilman khil...@linaro.org: Subject: [PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors Use the atomic64_* accessors for all the kernel_cpustat fields to ensure atomic access on non-64 bit platforms. Thanks to Mats

Re: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

2013-02-21 Thread Russell King - ARM Linux
On Thu, Feb 21, 2013 at 10:53:07PM +0100, Frederic Weisbecker wrote: That too should be kcpustat_this_cpu_set(), or kcpustat_this_cpu_add() FWIW. But we probably don't need the overhead of atomic_add() that does a LOCK. atomic_set(var, atomic_read(var) + delta) would be better. All we need

Re: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

2013-02-21 Thread Frederic Weisbecker
2013/2/21 Russell King - ARM Linux li...@arm.linux.org.uk: On Thu, Feb 21, 2013 at 10:53:07PM +0100, Frederic Weisbecker wrote: That too should be kcpustat_this_cpu_set(), or kcpustat_this_cpu_add() FWIW. But we probably don't need the overhead of atomic_add() that does a LOCK.

Re: [RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

2013-02-21 Thread Kevin Hilman
Frederic Weisbecker fweis...@gmail.com writes: 2013/2/21 Frederic Weisbecker fweis...@gmail.com: 2013/2/21 Kevin Hilman khil...@linaro.org: Subject: [PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors Use the atomic64_* accessors for all the kernel_cpustat fields to ensure atomic

[RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

2013-02-20 Thread Kevin Hilman
Use the atomic64_* accessors for all the kernel_cpustat fields to ensure atomic access on non-64 bit platforms. Thanks to Mats Liljegren for CGROUP_CPUACCT related fixes. Cc: Mats Liljegren Signed-off-by: Kevin Hilman --- fs/proc/stat.c | 40

[RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

2013-02-20 Thread Kevin Hilman
Use the atomic64_* accessors for all the kernel_cpustat fields to ensure atomic access on non-64 bit platforms. Thanks to Mats Liljegren for CGROUP_CPUACCT related fixes. Cc: Mats Liljegren mats.liljeg...@enea.com Signed-off-by: Kevin Hilman khil...@linaro.org --- fs/proc/stat.c |