Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

2015-11-02 Thread Brendan Gregg
On Thu, Oct 22, 2015 at 7:03 AM, Arnaldo Carvalho de Melo wrote: > Em Thu, Oct 22, 2015 at 02:49:11AM -0700, Brendan Gregg escreveu: >> On Thu, Oct 22, 2015 at 12:38 AM, Namhyung Kim wrote: >> > Hi Ingo, >> > >> > On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar wrote: >> >> >> >> * Namhyung Kim wr

Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

2015-10-22 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 23, 2015 at 12:51:01AM +0900, Namhyung Kim escreveu: > On Thu, Oct 22, 2015 at 11:37 PM, Arnaldo Carvalho de Melo > wrote: > > Will we also flip the default to --no-children? I would advocate that, > > together with showing a info box telling the user about this change and > > how to

Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

2015-10-22 Thread Namhyung Kim
On Thu, Oct 22, 2015 at 11:37 PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Oct 22, 2015 at 11:22:40PM +0900, Namhyung Kim escreveu: >> On Thu, Oct 22, 2015 at 11:13 PM, Arnaldo Carvalho de Melo >> wrote: >> > Em Thu, Oct 22, 2015 at 03:28:50PM +0900, Namhyung Kim escreveu: >> >> +++ b/tools/per

Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

2015-10-22 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 22, 2015 at 11:22:40PM +0900, Namhyung Kim escreveu: > On Thu, Oct 22, 2015 at 11:13 PM, Arnaldo Carvalho de Melo > wrote: > > Em Thu, Oct 22, 2015 at 03:28:50PM +0900, Namhyung Kim escreveu: > >> +++ b/tools/perf/util/util.c > >> @@ -19,7 +19,7 @@ > >> struct callchain_param c

Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

2015-10-22 Thread Namhyung Kim
Hi Arnaldo, On Thu, Oct 22, 2015 at 11:13 PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Oct 22, 2015 at 03:28:50PM +0900, Namhyung Kim escreveu: >> +++ b/tools/perf/util/util.c >> @@ -19,7 +19,7 @@ >> struct callchain_param callchain_param = { >> .mode = CHAIN_GRAPH_ABS, >> .

Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

2015-10-22 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 22, 2015 at 03:28:50PM +0900, Namhyung Kim escreveu: > +++ b/tools/perf/util/util.c > @@ -19,7 +19,7 @@ > struct callchain_param callchain_param = { > .mode = CHAIN_GRAPH_ABS, > .min_percent = 0.5, > - .order = ORDER_CALLER, > + .order = ORDER_CALLEE, >

Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

2015-10-22 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 22, 2015 at 02:49:11AM -0700, Brendan Gregg escreveu: > On Thu, Oct 22, 2015 at 12:38 AM, Namhyung Kim wrote: > > Hi Ingo, > > > > On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar wrote: > >> > >> * Namhyung Kim wrote: > >> > >>> The caller callchain order is useful with --children optio

Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

2015-10-22 Thread Frederic Weisbecker
On Thu, Oct 22, 2015 at 04:38:44PM +0900, Namhyung Kim wrote: > Hi Ingo, > > On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar wrote: > > > > * Namhyung Kim wrote: > > > >> The caller callchain order is useful with --children option since it can > >> show 'overview' style output, but other commands w

Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

2015-10-22 Thread Frederic Weisbecker
On Thu, Oct 22, 2015 at 03:28:50PM +0900, Namhyung Kim wrote: > The caller callchain order is useful with --children option since it can > show 'overview' style output, but other commands which don't use > --children feature like 'perf script' or even 'perf report/top' without > --children are be

Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

2015-10-22 Thread Brendan Gregg
On Thu, Oct 22, 2015 at 12:38 AM, Namhyung Kim wrote: > Hi Ingo, > > On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar wrote: >> >> * Namhyung Kim wrote: >> >>> The caller callchain order is useful with --children option since it can >>> show 'overview' style output, but other commands which don't us

Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

2015-10-22 Thread Namhyung Kim
Hi Ingo, On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar wrote: > > * Namhyung Kim wrote: > >> The caller callchain order is useful with --children option since it can >> show 'overview' style output, but other commands which don't use >> --children feature like 'perf script' or even 'perf report/

Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

2015-10-22 Thread Ingo Molnar
* Namhyung Kim wrote: > The caller callchain order is useful with --children option since it can > show 'overview' style output, but other commands which don't use > --children feature like 'perf script' or even 'perf report/top' without > --children are better to keep caller order. > > Cc: A

[RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

2015-10-21 Thread Namhyung Kim
The caller callchain order is useful with --children option since it can show 'overview' style output, but other commands which don't use --children feature like 'perf script' or even 'perf report/top' without --children are better to keep caller order. Cc: Adrian Hunter Cc: Borislav Petkov Cc