Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-24 Thread Namhyung Kim
Hi Arun, On Mon, 23 Dec 2013 14:46:17 +0530, Arun Sharma wrote: > On 12/18/13 8:09 PM, Namhyung Kim wrote: >> Hi Arun, >> >> 2013-12-18 (수), 16:08 +0530, Arun Sharma: >>> On 12/18/13 3:16 PM, Ingo Molnar wrote: >>> My main complaint that any variation of 'cumulative' or 'cumulate' is a

Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-24 Thread Namhyung Kim
Hi Arun, On Mon, 23 Dec 2013 14:46:17 +0530, Arun Sharma wrote: On 12/18/13 8:09 PM, Namhyung Kim wrote: Hi Arun, 2013-12-18 (수), 16:08 +0530, Arun Sharma: On 12/18/13 3:16 PM, Ingo Molnar wrote: My main complaint that any variation of 'cumulative' or 'cumulate' is a tongue-twister to

Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-23 Thread Arun Sharma
On 12/18/13 8:09 PM, Namhyung Kim wrote: Hi Arun, 2013-12-18 (수), 16:08 +0530, Arun Sharma: On 12/18/13 3:16 PM, Ingo Molnar wrote: My main complaint that any variation of 'cumulative' or 'cumulate' is a tongue-twister to users. I certainly won't be able to remember it and will have to call

Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-23 Thread Arun Sharma
On 12/18/13 8:09 PM, Namhyung Kim wrote: Hi Arun, 2013-12-18 (수), 16:08 +0530, Arun Sharma: On 12/18/13 3:16 PM, Ingo Molnar wrote: My main complaint that any variation of 'cumulative' or 'cumulate' is a tongue-twister to users. I certainly won't be able to remember it and will have to call

Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-18 Thread Namhyung Kim
On Wed, 18 Dec 2013 14:47:15 -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Dec 18, 2013 at 11:37:49PM +0900, Namhyung Kim escreveu: >> 2013-12-18 (수), 10:46 +0100, Ingo Molnar: >> > * Namhyung Kim wrote: > >> > > I changed the option as a separate --cumulate and added a new >> > > "Total"

Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-18 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 18, 2013 at 11:37:49PM +0900, Namhyung Kim escreveu: > 2013-12-18 (수), 10:46 +0100, Ingo Molnar: > > * Namhyung Kim wrote: > > > I changed the option as a separate --cumulate and added a new > > > "Total" column (and renamed the default "Overhead" column into > > > "Self"). The

Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-18 Thread Namhyung Kim
Hi Arun, 2013-12-18 (수), 16:08 +0530, Arun Sharma: > On 12/18/13 3:16 PM, Ingo Molnar wrote: > > > My main complaint that any variation of 'cumulative' or 'cumulate' is > > a tongue-twister to users. I certainly won't be able to remember it > > and will have to call up the manpage every time I

Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-18 Thread Namhyung Kim
2013-12-18 (수), 10:46 +0100, Ingo Molnar: > * Namhyung Kim wrote: > > > I changed the option as a separate --cumulate and added a new > > "Total" column (and renamed the default "Overhead" column into > > "Self"). The output will be sorted by total (cumulative) overhead > > for now. The

Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-18 Thread Arun Sharma
On 12/18/13 3:16 PM, Ingo Molnar wrote: My main complaint that any variation of 'cumulative' or 'cumulate' is a tongue-twister to users. I certainly won't be able to remember it and will have to call up the manpage every time I use it - which will be very annoying. I'd probably not use the

Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-18 Thread Ingo Molnar
* Namhyung Kim wrote: > I changed the option as a separate --cumulate and added a new > "Total" column (and renamed the default "Overhead" column into > "Self"). The output will be sorted by total (cumulative) overhead > for now. The reason I changed to the --cumulate is that I still >

Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-18 Thread Ingo Molnar
* Namhyung Kim namhy...@kernel.org wrote: I changed the option as a separate --cumulate and added a new Total column (and renamed the default Overhead column into Self). The output will be sorted by total (cumulative) overhead for now. The reason I changed to the --cumulate is that I

Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-18 Thread Arun Sharma
On 12/18/13 3:16 PM, Ingo Molnar wrote: My main complaint that any variation of 'cumulative' or 'cumulate' is a tongue-twister to users. I certainly won't be able to remember it and will have to call up the manpage every time I use it - which will be very annoying. I'd probably not use the

Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-18 Thread Namhyung Kim
2013-12-18 (수), 10:46 +0100, Ingo Molnar: * Namhyung Kim namhy...@kernel.org wrote: I changed the option as a separate --cumulate and added a new Total column (and renamed the default Overhead column into Self). The output will be sorted by total (cumulative) overhead for now. The

Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-18 Thread Namhyung Kim
Hi Arun, 2013-12-18 (수), 16:08 +0530, Arun Sharma: On 12/18/13 3:16 PM, Ingo Molnar wrote: My main complaint that any variation of 'cumulative' or 'cumulate' is a tongue-twister to users. I certainly won't be able to remember it and will have to call up the manpage every time I use it -

Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-18 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 18, 2013 at 11:37:49PM +0900, Namhyung Kim escreveu: 2013-12-18 (수), 10:46 +0100, Ingo Molnar: * Namhyung Kim namhy...@kernel.org wrote: I changed the option as a separate --cumulate and added a new Total column (and renamed the default Overhead column into Self). The

Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-18 Thread Namhyung Kim
On Wed, 18 Dec 2013 14:47:15 -0300, Arnaldo Carvalho de Melo wrote: Em Wed, Dec 18, 2013 at 11:37:49PM +0900, Namhyung Kim escreveu: 2013-12-18 (수), 10:46 +0100, Ingo Molnar: * Namhyung Kim namhy...@kernel.org wrote: I changed the option as a separate --cumulate and added a new Total

[RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-17 Thread Namhyung Kim
Hello, This is my third attempt to implement cumulative hist period report. This work begins from Arun's SORT_INCLUSIVE patch [1] but I completely rewrote it from scratch. Please see the patch 04/18. I refactored functions that add hist entries with struct add_entry_iter. While I converted all

[RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)

2013-12-17 Thread Namhyung Kim
Hello, This is my third attempt to implement cumulative hist period report. This work begins from Arun's SORT_INCLUSIVE patch [1] but I completely rewrote it from scratch. Please see the patch 04/18. I refactored functions that add hist entries with struct add_entry_iter. While I converted all