Re: [RFC: 2.6 patch] drivers/acpi/: possible cleanups

2005-01-30 Thread Christoph Hellwig
On Thu, Jan 27, 2005 at 06:04:20PM -0500, Len Brown wrote: > I've already asked Bob Moore to migrate to the use of static in the > interpreter. There are some somewhat urgent functional issues he needs > to focus on first, but static is on the list. If we allow him to do it > upstream (w/o lookin

Re: [RFC: 2.6 patch] drivers/acpi/: possible cleanups

2005-01-27 Thread Dmitry Torokhov
On Thursday 27 January 2005 18:04, Len Brown wrote: > Thanks for the patch Adrian. > > I agree that this is the right direction to go -- enforcing APIs with > the use of static reduces the possibility of programming errors -- > particularly with many cooks in the kitchen. ÂIndeed, just on Monday w

Re: [RFC: 2.6 patch] drivers/acpi/: possible cleanups

2005-01-27 Thread Len Brown
On Thu, 2005-01-27 at 06:01, Adrian Bunk wrote: > Before I'm getting flamed to death: > This patch isn't meant for being immediately applied. > > This patch makes all needlessly global code under drivers/acpi/ > static. > Please review this patch. Thanks for the patch Adrian. I agree that this i