Re: [RFC: PATCH v5] i2c: exynos5: add High Speed I2C controller driver

2013-03-26 Thread Wolfram Sang
> > + /* CLK_DIV max is 256 */ > > + for (i = 0; i < 256; i++) { > > + utemp1 = utemp0 / (i + 1); > > + /* SCLK_L/H max is 256 / 2 */ > > + if (utemp1 < 128) { > I think TSCLK_L and TSCLK_H both can be configured upto 255.Why > limiting it to

Re: [RFC: PATCH v5] i2c: exynos5: add High Speed I2C controller driver

2013-03-26 Thread Wolfram Sang
+ /* CLK_DIV max is 256 */ + for (i = 0; i 256; i++) { + utemp1 = utemp0 / (i + 1); + /* SCLK_L/H max is 256 / 2 */ + if (utemp1 128) { I think TSCLK_L and TSCLK_H both can be configured upto 255.Why limiting it to 128 ? By

Re: [RFC: PATCH v5] i2c: exynos5: add High Speed I2C controller driver

2013-03-25 Thread Yuvaraj CD
On Wed, Mar 20, 2013 at 9:54 PM, Naveen Krishna Chatradhi wrote: > Adds support for High Speed I2C driver found in Exynos5 and later > SoCs from Samsung. This driver currently supports Auto mode. > > Driver only supports Device Tree method. > Note: Added debugfs support for registers view, not

Re: [RFC: PATCH v5] i2c: exynos5: add High Speed I2C controller driver

2013-03-25 Thread Yuvaraj CD
On Wed, Mar 20, 2013 at 9:54 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: Adds support for High Speed I2C driver found in Exynos5 and later SoCs from Samsung. This driver currently supports Auto mode. Driver only supports Device Tree method. Note: Added debugfs support for

[RFC: PATCH v5] i2c: exynos5: add High Speed I2C controller driver

2013-03-20 Thread Naveen Krishna Chatradhi
Adds support for High Speed I2C driver found in Exynos5 and later SoCs from Samsung. This driver currently supports Auto mode. Driver only supports Device Tree method. Note: Added debugfs support for registers view, not tested. Signed-off-by: Taekgyun Ko Signed-off-by: Naveen Krishna Chatradhi

[RFC: PATCH v5] i2c: exynos5: add High Speed I2C controller driver

2013-03-20 Thread Naveen Krishna Chatradhi
Adds support for High Speed I2C driver found in Exynos5 and later SoCs from Samsung. This driver currently supports Auto mode. Driver only supports Device Tree method. Note: Added debugfs support for registers view, not tested. Signed-off-by: Taekgyun Ko taeggyun...@samsung.com Signed-off-by: