Re: [RFC][PATCH] cpu_pm: Remove RCU abuse

2020-09-03 Thread Ulf Hansson
On Thu, 3 Sep 2020 at 17:08, wrote: > > On Thu, Sep 03, 2020 at 04:36:35PM +0200, Ulf Hansson wrote: > > On Thu, 3 Sep 2020 at 15:53, wrote: > > > static int cpu_pm_notify(enum cpu_pm_event event) > > > { > > > int ret; > > > > > > + lockdep_assert_irqs_disabled(); > > > > Nitpick

Re: [RFC][PATCH] cpu_pm: Remove RCU abuse

2020-09-03 Thread Paul E. McKenney
On Thu, Sep 03, 2020 at 05:08:19PM +0200, pet...@infradead.org wrote: > On Thu, Sep 03, 2020 at 04:36:35PM +0200, Ulf Hansson wrote: > > On Thu, 3 Sep 2020 at 15:53, wrote: > > > static int cpu_pm_notify(enum cpu_pm_event event) > > > { > > > int ret; > > > > > > + lockdep_assert_i

Re: [RFC][PATCH] cpu_pm: Remove RCU abuse

2020-09-03 Thread peterz
On Thu, Sep 03, 2020 at 04:36:35PM +0200, Ulf Hansson wrote: > On Thu, 3 Sep 2020 at 15:53, wrote: > > static int cpu_pm_notify(enum cpu_pm_event event) > > { > > int ret; > > > > + lockdep_assert_irqs_disabled(); > > Nitpick, maybe the lockdep should be moved to a separate patch.

[RFC][PATCH] cpu_pm: Remove RCU abuse

2020-09-03 Thread peterz
On Wed, Sep 02, 2020 at 05:58:55PM +0200, Ulf Hansson wrote: > On Wed, 2 Sep 2020 at 14:14, wrote: > > > > On Wed, Sep 02, 2020 at 09:03:37AM +0200, Ulf Hansson wrote: > > > Lots of cpuidle drivers are using CPU_PM notifiers (grep for > > > cpu_pm_enter and you will see) from their idlestates ->en

Re: [RFC][PATCH] cpu_pm: Remove RCU abuse

2020-09-03 Thread Ulf Hansson
On Thu, 3 Sep 2020 at 15:53, wrote: > > On Wed, Sep 02, 2020 at 05:58:55PM +0200, Ulf Hansson wrote: > > On Wed, 2 Sep 2020 at 14:14, wrote: > > > > > > On Wed, Sep 02, 2020 at 09:03:37AM +0200, Ulf Hansson wrote: > > > > Lots of cpuidle drivers are using CPU_PM notifiers (grep for > > > > cpu_pm