Re: [RFC][PATCH] ftrace/x86: Remove mcount support

2019-05-10 Thread Jiri Kosina
On Thu, 9 May 2019, Steven Rostedt wrote: > As this patch is simply a "remove mcount" patch, I'd like to have the > removal of klp_check_compiler_support() be a separate patch. > > Jiri or Josh, care to send a patch on top of this one? Sure thing, I'll do that once you send v2 fixing x86_32 of

Re: [RFC][PATCH] ftrace/x86: Remove mcount support

2019-05-09 Thread Steven Rostedt
On Thu, 9 May 2019 15:49:02 -0400 Steven Rostedt wrote: > diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h > index cf350639e76d..287f1f7b2e52 100644 > --- a/arch/x86/include/asm/ftrace.h > +++ b/arch/x86/include/asm/ftrace.h > @@ -3,12 +3,10 @@ > #define

Re: [RFC][PATCH] ftrace/x86: Remove mcount support

2019-05-09 Thread Steven Rostedt
On Thu, 9 May 2019 15:14:30 -0500 Josh Poimboeuf wrote: > > Signed-off-by: Steven Rostedt (VMware) > > --- > > arch/x86/include/asm/ftrace.h| 8 +++ > > arch/x86/include/asm/livepatch.h | 3 --- > > arch/x86/kernel/ftrace_32.S | 36 +--- > >

Re: [RFC][PATCH] ftrace/x86: Remove mcount support

2019-05-09 Thread Steven Rostedt
On Thu, 9 May 2019 13:12:55 -0700 Linus Torvalds wrote: > On Thu, May 9, 2019 at 12:49 PM Steven Rostedt wrote: > > > > diff --git a/arch/x86/include/asm/livepatch.h > > b/arch/x86/include/asm/livepatch.h > > index ed80003ce3e2..2f2bdf0662f8 100644 > > --- a/arch/x86/include/asm/livepatch.h >

Re: [RFC][PATCH] ftrace/x86: Remove mcount support

2019-05-09 Thread Josh Poimboeuf
On Thu, May 09, 2019 at 03:49:02PM -0400, Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > There's two methods of enabling function tracing in Linux on x86. One is > with just "gcc -pg" and the other is "gcc -pg -mfentry". The former will use > calls to a special function "mcount"

Re: [RFC][PATCH] ftrace/x86: Remove mcount support

2019-05-09 Thread Linus Torvalds
On Thu, May 9, 2019 at 12:49 PM Steven Rostedt wrote: > > diff --git a/arch/x86/include/asm/livepatch.h > b/arch/x86/include/asm/livepatch.h > index ed80003ce3e2..2f2bdf0662f8 100644 > --- a/arch/x86/include/asm/livepatch.h > +++ b/arch/x86/include/asm/livepatch.h > @@ -26,9 +26,6 @@ > > static

Re: [RFC][PATCH] ftrace/x86: Remove mcount support

2019-05-09 Thread Jiri Kosina
On Thu, 9 May 2019, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > There's two methods of enabling function tracing in Linux on x86. One is > with just "gcc -pg" and the other is "gcc -pg -mfentry". The former will use > calls to a special function "mcount" after the frame is set

Re: [RFC][PATCH] ftrace/x86: Remove mcount support

2019-05-09 Thread Peter Zijlstra
On Thu, May 09, 2019 at 03:49:02PM -0400, Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > There's two methods of enabling function tracing in Linux on x86. One is > with just "gcc -pg" and the other is "gcc -pg -mfentry". The former will use > calls to a special function "mcount"

[RFC][PATCH] ftrace/x86: Remove mcount support

2019-05-09 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" There's two methods of enabling function tracing in Linux on x86. One is with just "gcc -pg" and the other is "gcc -pg -mfentry". The former will use calls to a special function "mcount" after the frame is set up in all C functions. The latter will add calls to