Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On Mon, 27 Jun 2016 11:40:42 -0600 Shuah Khan wrote: > Could you please send the patch. I don't see the patch in my inbox. > I can get this into 4.8-rc1 > Ah, sorry, I should have sent this to you. Instead, I already pushed it up to Linus and it is already in

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On Mon, 27 Jun 2016 11:40:42 -0600 Shuah Khan wrote: > Could you please send the patch. I don't see the patch in my inbox. > I can get this into 4.8-rc1 > Ah, sorry, I should have sent this to you. Instead, I already pushed it up to Linus and it is already in Mainline. Commit:

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On 06/19/2016 05:42 PM, Namhyung Kim wrote: > On Fri, Jun 17, 2016 at 05:28:47PM -0400, Steven Rostedt wrote: >> Ah, due to traveling I never got around to finishing this. What about >> this patch? >> >> From 7bf19b58ba02e66014efce6c051acba2c6cbd861 Mon Sep 17 00:00:00 2001 >> From: "Steven

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On 06/19/2016 05:42 PM, Namhyung Kim wrote: > On Fri, Jun 17, 2016 at 05:28:47PM -0400, Steven Rostedt wrote: >> Ah, due to traveling I never got around to finishing this. What about >> this patch? >> >> From 7bf19b58ba02e66014efce6c051acba2c6cbd861 Mon Sep 17 00:00:00 2001 >> From: "Steven

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On Fri, Jun 17, 2016 at 05:28:47PM -0400, Steven Rostedt wrote: > Ah, due to traveling I never got around to finishing this. What about > this patch? > > From 7bf19b58ba02e66014efce6c051acba2c6cbd861 Mon Sep 17 00:00:00 2001 > From: "Steven Rostedt (Red Hat)" > Date: Mon, 23

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On Fri, Jun 17, 2016 at 05:28:47PM -0400, Steven Rostedt wrote: > Ah, due to traveling I never got around to finishing this. What about > this patch? > > From 7bf19b58ba02e66014efce6c051acba2c6cbd861 Mon Sep 17 00:00:00 2001 > From: "Steven Rostedt (Red Hat)" > Date: Mon, 23 May 2016 15:06:30

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On Fri, 17 Jun 2016 17:28:47 -0400 Steven Rostedt wrote: > On Tue, 24 May 2016 12:02:35 +0900 > Namhyung Kim wrote: > > > On Mon, May 23, 2016 at 10:32:43PM -0400, Steven Rostedt wrote: > > > On Tue, 24 May 2016 11:16:31 +0900 > > > Namhyung Kim

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On Fri, 17 Jun 2016 17:28:47 -0400 Steven Rostedt wrote: > On Tue, 24 May 2016 12:02:35 +0900 > Namhyung Kim wrote: > > > On Mon, May 23, 2016 at 10:32:43PM -0400, Steven Rostedt wrote: > > > On Tue, 24 May 2016 11:16:31 +0900 > > > Namhyung Kim wrote: > > > > > > > > > > Why not checking

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On Tue, 24 May 2016 12:02:35 +0900 Namhyung Kim wrote: > On Mon, May 23, 2016 at 10:32:43PM -0400, Steven Rostedt wrote: > > On Tue, 24 May 2016 11:16:31 +0900 > > Namhyung Kim wrote: > > > > > > > Why not checking "hist" file then? > > > > I

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On Tue, 24 May 2016 12:02:35 +0900 Namhyung Kim wrote: > On Mon, May 23, 2016 at 10:32:43PM -0400, Steven Rostedt wrote: > > On Tue, 24 May 2016 11:16:31 +0900 > > Namhyung Kim wrote: > > > > > > > Why not checking "hist" file then? > > > > I guess that could be done too, but is there

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On Mon, May 23, 2016 at 10:32:43PM -0400, Steven Rostedt wrote: > On Tue, 24 May 2016 11:16:31 +0900 > Namhyung Kim wrote: > > > > Why not checking "hist" file then? > > I guess that could be done too, but is there anything wrong with my > current solution? Or is it just

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On Mon, May 23, 2016 at 10:32:43PM -0400, Steven Rostedt wrote: > On Tue, 24 May 2016 11:16:31 +0900 > Namhyung Kim wrote: > > > > Why not checking "hist" file then? > > I guess that could be done too, but is there anything wrong with my > current solution? Or is it just too hacky? How would

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On Tue, 24 May 2016 11:16:31 +0900 Namhyung Kim wrote: > Why not checking "hist" file then? I guess that could be done too, but is there anything wrong with my current solution? Or is it just too hacky? How would one check if something exists in a file or not? Say, I want

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On Tue, 24 May 2016 11:16:31 +0900 Namhyung Kim wrote: > Why not checking "hist" file then? I guess that could be done too, but is there anything wrong with my current solution? Or is it just too hacky? How would one check if something exists in a file or not? Say, I want to detect if

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On Mon, May 23, 2016 at 09:50:45PM -0400, Steven Rostedt wrote: > On Tue, 24 May 2016 08:54:38 +0900 > Namhyung Kim wrote: > > > Hi Steve, > > > > On Mon, May 23, 2016 at 03:15:38PM -0400, Steven Rostedt wrote: > > > > > > [ Folks, is this a proper work around? ] > > > >

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On Mon, May 23, 2016 at 09:50:45PM -0400, Steven Rostedt wrote: > On Tue, 24 May 2016 08:54:38 +0900 > Namhyung Kim wrote: > > > Hi Steve, > > > > On Mon, May 23, 2016 at 03:15:38PM -0400, Steven Rostedt wrote: > > > > > > [ Folks, is this a proper work around? ] > > > > > > When histograms

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On Tue, 24 May 2016 08:54:38 +0900 Namhyung Kim wrote: > Hi Steve, > > On Mon, May 23, 2016 at 03:15:38PM -0400, Steven Rostedt wrote: > > > > [ Folks, is this a proper work around? ] > > > > When histograms are not configured in the kernel, the ftracetest histogram > >

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

On Tue, 24 May 2016 08:54:38 +0900 Namhyung Kim wrote: > Hi Steve, > > On Mon, May 23, 2016 at 03:15:38PM -0400, Steven Rostedt wrote: > > > > [ Folks, is this a proper work around? ] > > > > When histograms are not configured in the kernel, the ftracetest histogram > > selftests should

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

Hi Steve, On Mon, May 23, 2016 at 03:15:38PM -0400, Steven Rostedt wrote: > > [ Folks, is this a proper work around? ] > > When histograms are not configured in the kernel, the ftracetest histogram > selftests should return "unsupported" and not "Failed". To detect this, the > test scripts

Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

Hi Steve, On Mon, May 23, 2016 at 03:15:38PM -0400, Steven Rostedt wrote: > > [ Folks, is this a proper work around? ] > > When histograms are not configured in the kernel, the ftracetest histogram > selftests should return "unsupported" and not "Failed". To detect this, the > test scripts

[RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

[ Folks, is this a proper work around? ] When histograms are not configured in the kernel, the ftracetest histogram selftests should return "unsupported" and not "Failed". To detect this, the test scripts have: FEATURE=`grep hist events/sched/sched_process_fork/trigger` if [ -z "$FEATURE" ];

[RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

[ Folks, is this a proper work around? ] When histograms are not configured in the kernel, the ftracetest histogram selftests should return "unsupported" and not "Failed". To detect this, the test scripts have: FEATURE=`grep hist events/sched/sched_process_fork/trigger` if [ -z "$FEATURE" ];