Re: [RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations

2007-09-28 Thread Christoph Hellwig
On Thu, Sep 27, 2007 at 02:51:25PM -0700, Andrew Morton wrote: > That'll be because reiserfs-convert-to-new-aops.patch witched reiserfs over > to ->write_begin() and ->write_end(). Yeah, I was looking at mainline. > So your stuff becomes dependent on Nick's stuff, and Nick's stuff is still > fail

Re: [RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations

2007-09-27 Thread Peter Zijlstra
On Thu, 2007-09-27 at 14:51 -0700, Andrew Morton wrote: > So your stuff becomes dependent on Nick's stuff, and Nick's stuff is still > failing on NFS, I think. It worked today, it turned out to be a UML bug. Real hardware seemed to work properly, but will test a bit more tomorrow. - To unsubscr

Re: [RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 14:51:25 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > > Plus, reiserfs seems to compile with that patch I just sent. Sure as > > heck surprised me. > > > > That'll be because reiserfs-convert-to-new-aops.patch witched reiserfs over > to ->write_begin() and ->write_end().

Re: [RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 14:27:14 -0700 Dave Hansen <[EMAIL PROTECTED]> wrote: > On Thu, 2007-09-27 at 22:04 +0100, Christoph Hellwig wrote: > > On Thu, Sep 27, 2007 at 01:53:39PM -0700, Dave Hansen wrote: > > > -int reiserfs_commit_write(struct file *f, struct page *page, > > > - uns

Re: [RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations

2007-09-27 Thread Dave Hansen
On Thu, 2007-09-27 at 22:04 +0100, Christoph Hellwig wrote: > On Thu, Sep 27, 2007 at 01:53:39PM -0700, Dave Hansen wrote: > > -int reiserfs_commit_write(struct file *f, struct page *page, > > - unsigned from, unsigned to); > > -int reiserfs_prepare_write(struct file *f, struct

Re: [RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations

2007-09-27 Thread Christoph Hellwig
On Thu, Sep 27, 2007 at 01:53:39PM -0700, Dave Hansen wrote: > -int reiserfs_commit_write(struct file *f, struct page *page, > - unsigned from, unsigned to); > -int reiserfs_prepare_write(struct file *f, struct page *page, > -unsigned from, unsigned to)

[RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations

2007-09-27 Thread Dave Hansen
On Thu, 2007-09-27 at 21:26 +0100, Christoph Hellwig wrote: > > Dave will probably find a bandaid to work around this, but the > right fix is to stop using a file struct here entirely. If you > look at reiserfs_xattr_set it's not actually used at all except > for passing it to ->prepare_write and