Re: [RFC][PATCH] module: Limit line length of module prints

2015-12-15 Thread Laura Abbott
On 12/13/2015 05:06 PM, Rusty Russell wrote: Laura Abbott writes: On 12/11/2015 01:39 AM, Rusty Russell wrote: Laura Abbott writes: print_modules currently uses pr_cont to print all module information. This has the side effect of printing lots of modules on one very long line. This makes cop

Re: [RFC][PATCH] module: Limit line length of module prints

2015-12-13 Thread Rusty Russell
Laura Abbott writes: > On 12/11/2015 01:39 AM, Rusty Russell wrote: >> Laura Abbott writes: >>> print_modules currently uses pr_cont to print all module information. >>> This has the side effect of printing lots of modules on one very long >>> line. This makes copy/pasting oopses more effort if m

Re: [RFC][PATCH] module: Limit line length of module prints

2015-12-11 Thread Laura Abbott
On 12/11/2015 01:39 AM, Rusty Russell wrote: Laura Abbott writes: print_modules currently uses pr_cont to print all module information. This has the side effect of printing lots of modules on one very long line. This makes copy/pasting oopses more effort if manual wrapping is required. Place a

Re: [RFC][PATCH] module: Limit line length of module prints

2015-12-11 Thread Laura Abbott
On 12/11/2015 01:36 AM, Geyslan G. Bem wrote: Hello, What do you think of get the strlen of name and module_flags before printing them? So the check against MAX CHARS would be more precise and uniform. Or the limit is not strictly necessary? It's not really necessary. If it goes over a littl

Re: [RFC][PATCH] module: Limit line length of module prints

2015-12-11 Thread Rusty Russell
Laura Abbott writes: > print_modules currently uses pr_cont to print all module information. > This has the side effect of printing lots of modules on one very long > line. This makes copy/pasting oopses more effort if manual wrapping is > required. Place a reasonable limit (80 chars) on the numbe

[RFC][PATCH] module: Limit line length of module prints

2015-12-10 Thread Laura Abbott
print_modules currently uses pr_cont to print all module information. This has the side effect of printing lots of modules on one very long line. This makes copy/pasting oopses more effort if manual wrapping is required. Place a reasonable limit (80 chars) on the number of modules on each line. Si