Re: [RFC][PATCH] printk: Add option to append kernel version to the dict

2016-05-17 Thread Tejun Heo
On Wed, May 18, 2016 at 12:43:10AM +0900, Sergey Senozhatsky wrote: > > Given that most of the messages are written minding typical console > > widths, whether for editing or outputting, I don't think that's a > > practical concern. We're not talking about appending kilobytes worth > > of addition

Re: [RFC][PATCH] printk: Add option to append kernel version to the dict

2016-05-17 Thread Sergey Senozhatsky
Hello Tejun, On (05/17/16 06:51), Tejun Heo wrote: > On Tue, May 17, 2016 at 11:42:57PM +0900, Sergey Senozhatsky wrote: > > > > what if there is no place left for init_utsname() after > > > > msg_print_ext_header() + msg_print_ext_body()? > > > > > > It ends up being truncated, like either of th

Re: [RFC][PATCH] printk: Add option to append kernel version to the dict

2016-05-17 Thread Tejun Heo
On Tue, May 17, 2016 at 11:42:57PM +0900, Sergey Senozhatsky wrote: > > > what if there is no place left for init_utsname() after > > > msg_print_ext_header() + msg_print_ext_body()? > > > > It ends up being truncated, like either of the preceeding calls would. > > well, I meant once it's truncat

Re: [RFC][PATCH] printk: Add option to append kernel version to the dict

2016-05-17 Thread Sergey Senozhatsky
On (05/16/16 15:02), Calvin Owens wrote: [..] > > > @@ -2305,6 +2317,8 @@ skip: > > > sizeof(ext_text) - ext_len, > > > log_dict(msg), msg->dict_len, > > > log_text(msg), ms

Re: [RFC][PATCH] printk: Add option to append kernel version to the dict

2016-05-17 Thread Tejun Heo
Hello, On Tue, May 17, 2016 at 11:24:46AM +0200, Petr Mladek wrote: > The risk is that someone else might need another information. > If we do it more generic, we might end up with quite complex code. It can be pretty simple given that there's no real ordering or formatting involved. enum {

Re: [RFC][PATCH] printk: Add option to append kernel version to the dict

2016-05-17 Thread Petr Mladek
On Fri 2016-05-13 13:58:04, Calvin Owens wrote: > We use netconsole to collect kernel logs from all the servers at > Facebook. We use this patch internally so each logline has a record of > which kernel version emitted it. > > At first glance, this might seem lazy: as you would expect, we have a >

Re: [RFC][PATCH] printk: Add option to append kernel version to the dict

2016-05-16 Thread Calvin Owens
On Sunday 05/15 at 15:36 +0900, Sergey Senozhatsky wrote: > Hello, > > On (05/13/16 13:58), Calvin Owens wrote: > [..] > > +#if defined(CONFIG_PRINTK_APPEND_UNAME) > > +static ssize_t msg_print_ext_uname(char *buf, size_t size) > > +{ > > + return scnprintf(buf, size, " UNAME=%s\n", init_utsname

Re: [RFC][PATCH] printk: Add option to append kernel version to the dict

2016-05-16 Thread Calvin Owens
On Sunday 05/15 at 00:19 +0200, Richard Weinberger wrote: > On Fri, May 13, 2016 at 10:58 PM, Calvin Owens wrote: > > We use netconsole to collect kernel logs from all the servers at > > Facebook. We use this patch internally so each logline has a record of > > which kernel version emitted it. > >

Re: [RFC][PATCH] printk: Add option to append kernel version to the dict

2016-05-14 Thread Sergey Senozhatsky
Hello, On (05/13/16 13:58), Calvin Owens wrote: [..] > +#if defined(CONFIG_PRINTK_APPEND_UNAME) > +static ssize_t msg_print_ext_uname(char *buf, size_t size) > +{ > + return scnprintf(buf, size, " UNAME=%s\n", init_utsname()->release); > +} > +#else > +static ssize_t msg_print_ext_uname(char *

Re: [RFC][PATCH] printk: Add option to append kernel version to the dict

2016-05-14 Thread Richard Weinberger
On Fri, May 13, 2016 at 10:58 PM, Calvin Owens wrote: > We use netconsole to collect kernel logs from all the servers at > Facebook. We use this patch internally so each logline has a record of > which kernel version emitted it. > > At first glance, this might seem lazy: as you would expect, we ha

[RFC][PATCH] printk: Add option to append kernel version to the dict

2016-05-13 Thread Calvin Owens
We use netconsole to collect kernel logs from all the servers at Facebook. We use this patch internally so each logline has a record of which kernel version emitted it. At first glance, this might seem lazy: as you would expect, we have a database which records which kernel version a host is curre