Re: [RFC][PATCH] rip out x86_32 NUMA remapping code

2013-01-31 Thread H. Peter Anvin
On 01/31/2013 02:09 PM, Dave Hansen wrote: > On 01/31/2013 02:03 PM, H. Peter Anvin wrote: >> That is arch-independent code, and the tile architecture still uses it. >> >> Makes one wonder how much it will get tested going forward, especially >> with the x86-32 implementation clearly lacking in tha

Re: [RFC][PATCH] rip out x86_32 NUMA remapping code

2013-01-31 Thread Dave Hansen
On 01/31/2013 02:03 PM, H. Peter Anvin wrote: > That is arch-independent code, and the tile architecture still uses it. > > Makes one wonder how much it will get tested going forward, especially > with the x86-32 implementation clearly lacking in that department. Yeah, I left the tile one because

Re: [RFC][PATCH] rip out x86_32 NUMA remapping code

2013-01-31 Thread H. Peter Anvin
On 01/31/2013 02:01 PM, Yinghai Lu wrote: > On Thu, Jan 31, 2013 at 1:59 PM, H. Peter Anvin wrote: >> On 01/31/2013 01:55 PM, Yinghai Lu wrote: >>> On Thu, Jan 31, 2013 at 1:51 PM, H. Peter Anvin wrote: I get a build failure on i386 allyesconfig with this patch: arch/x86/power/buil

Re: [RFC][PATCH] rip out x86_32 NUMA remapping code

2013-01-31 Thread Yinghai Lu
On Thu, Jan 31, 2013 at 1:59 PM, H. Peter Anvin wrote: > On 01/31/2013 01:55 PM, Yinghai Lu wrote: >> On Thu, Jan 31, 2013 at 1:51 PM, H. Peter Anvin wrote: >>> I get a build failure on i386 allyesconfig with this patch: >>> >>> arch/x86/power/built-in.o: In function `swsusp_arch_resume': >>> (.t

Re: [RFC][PATCH] rip out x86_32 NUMA remapping code

2013-01-31 Thread H. Peter Anvin
On 01/31/2013 01:55 PM, Yinghai Lu wrote: > On Thu, Jan 31, 2013 at 1:51 PM, H. Peter Anvin wrote: >> I get a build failure on i386 allyesconfig with this patch: >> >> arch/x86/power/built-in.o: In function `swsusp_arch_resume': >> (.text+0x14e4): undefined reference to `resume_map_numa_kva' >> >>

Re: [RFC][PATCH] rip out x86_32 NUMA remapping code

2013-01-31 Thread Yinghai Lu
On Thu, Jan 31, 2013 at 1:51 PM, H. Peter Anvin wrote: > I get a build failure on i386 allyesconfig with this patch: > > arch/x86/power/built-in.o: In function `swsusp_arch_resume': > (.text+0x14e4): undefined reference to `resume_map_numa_kva' > > It looks trivial to fix up; I assume resume_map_n

Re: [RFC][PATCH] rip out x86_32 NUMA remapping code

2013-01-31 Thread H. Peter Anvin
On 01/30/2013 04:56 PM, Dave Hansen wrote: > This code was an optimization for 32-bit NUMA systems. > > It has probably been the cause of a number of subtle bugs over > the years, although the conditions to excite them would have > been hard to trigger. Essentially, we remap part of the kernel >

Re: [RFC][PATCH] rip out x86_32 NUMA remapping code

2013-01-31 Thread H. Peter Anvin
On 01/30/2013 04:56 PM, Dave Hansen wrote: > This code was an optimization for 32-bit NUMA systems. > > It has probably been the cause of a number of subtle bugs over > the years, although the conditions to excite them would have > been hard to trigger. Essentially, we remap part of the kernel >

[RFC][PATCH] rip out x86_32 NUMA remapping code

2013-01-30 Thread Dave Hansen
This code was an optimization for 32-bit NUMA systems. It has probably been the cause of a number of subtle bugs over the years, although the conditions to excite them would have been hard to trigger. Essentially, we remap part of the kernel linear mapping area, and then sometimes part of that a