Re: [RFC][PATCH] sched: Cleanup task->state printing

2017-09-22 Thread Peter Zijlstra
On Fri, Sep 22, 2017 at 10:12:45AM -0400, Steven Rostedt wrote: > On Fri, 22 Sep 2017 13:54:30 +0200 > Peter Zijlstra wrote: > > > I should probably split this thing into a bunch of patches :/ > > Yes please. Convert form dec to hex in one patch and one patch only. Yeah,

Re: [RFC][PATCH] sched: Cleanup task->state printing

2017-09-22 Thread Peter Zijlstra
On Fri, Sep 22, 2017 at 10:12:45AM -0400, Steven Rostedt wrote: > On Fri, 22 Sep 2017 13:54:30 +0200 > Peter Zijlstra wrote: > > > I should probably split this thing into a bunch of patches :/ > > Yes please. Convert form dec to hex in one patch and one patch only. Yeah, was already on it, did

Re: [RFC][PATCH] sched: Cleanup task->state printing

2017-09-22 Thread Steven Rostedt
On Fri, 22 Sep 2017 13:54:30 +0200 Peter Zijlstra wrote: > I should probably split this thing into a bunch of patches :/ Yes please. Convert form dec to hex in one patch and one patch only. Because I'm not sure if you meant to change numbers or not. > /* Used in

Re: [RFC][PATCH] sched: Cleanup task->state printing

2017-09-22 Thread Steven Rostedt
On Fri, 22 Sep 2017 13:54:30 +0200 Peter Zijlstra wrote: > I should probably split this thing into a bunch of patches :/ Yes please. Convert form dec to hex in one patch and one patch only. Because I'm not sure if you meant to change numbers or not. > /* Used in tsk->state again: */ >

Re: [RFC][PATCH] sched: Cleanup task->state printing

2017-09-22 Thread Markus Trippelsdorf
On 2017.09.22 at 13:54 +0200, Peter Zijlstra wrote: > On Fri, Sep 22, 2017 at 11:35:33AM +0200, Markus Trippelsdorf wrote: > > > It seems to work. Simply returning "I (idle)" from get_task_state() in > > > fs/proc/array.c when the state is TASK_IDLE does the trick. > > > I've tested top, htop and

Re: [RFC][PATCH] sched: Cleanup task->state printing

2017-09-22 Thread Markus Trippelsdorf
On 2017.09.22 at 13:54 +0200, Peter Zijlstra wrote: > On Fri, Sep 22, 2017 at 11:35:33AM +0200, Markus Trippelsdorf wrote: > > > It seems to work. Simply returning "I (idle)" from get_task_state() in > > > fs/proc/array.c when the state is TASK_IDLE does the trick. > > > I've tested top, htop and

[RFC][PATCH] sched: Cleanup task->state printing

2017-09-22 Thread Peter Zijlstra
On Fri, Sep 22, 2017 at 11:35:33AM +0200, Markus Trippelsdorf wrote: > > It seems to work. Simply returning "I (idle)" from get_task_state() in > > fs/proc/array.c when the state is TASK_IDLE does the trick. > > I've tested top, htop and ps. I ended up with the below; there was quite a lot of

[RFC][PATCH] sched: Cleanup task->state printing

2017-09-22 Thread Peter Zijlstra
On Fri, Sep 22, 2017 at 11:35:33AM +0200, Markus Trippelsdorf wrote: > > It seems to work. Simply returning "I (idle)" from get_task_state() in > > fs/proc/array.c when the state is TASK_IDLE does the trick. > > I've tested top, htop and ps. I ended up with the below; there was quite a lot of