On Sun, Feb 13, 2005 at 01:04:56PM +0706, [EMAIL PROTECTED] wrote:
> On Wed, Feb 09, 2005 at 12:22:52AM +0100, Rafael J. Wysocki wrote:
> > On Tuesday, 8 of February 2005 23:42, Pavel Machek wrote:
> > > Hi!
> > >
> > > > +static inline void eat_page(void *page) {
> > >
> > > Please put { on new
On Wed, Feb 09, 2005 at 12:22:52AM +0100, Rafael J. Wysocki wrote:
> On Tuesday, 8 of February 2005 23:42, Pavel Machek wrote:
> > Hi!
> >
> > > +static inline void eat_page(void *page) {
> >
> > Please put { on new line.
>
> Oh, I still tend to forget about this. Corrected in the patch that is
On Tuesday, 8 of February 2005 23:42, Pavel Machek wrote:
> Hi!
>
> > +static inline void eat_page(void *page) {
>
> Please put { on new line.
Oh, I still tend to forget about this. Corrected in the patch that is
available on the web
(http://www.sisk.pl/kernel/patches/2.6.11-rc3-mm1/swsusp-use-
Hi!
> +static inline void eat_page(void *page) {
Please put { on new line.
Okay, as you can see, I could find very little wrong with this
patch. That hopefully means it is okay ;-). I should still check error
handling, but I guess I'll do it when it is applied because it is hard
to do on a diff.
On Tuesday, 8 of February 2005 20:10, Pavel Machek wrote:
> Hi!
>
> > > so it is okay, but...
> >
> > ... I could have done it more elegantly. You're right, I've now introduced
> > a function eat_page() that adds a page to the list of unusable pages and
> > used it instead of the free_page() he
Hi!
> > so it is okay, but...
>
> ... I could have done it more elegantly. You're right, I've now introduced
> a function eat_page() that adds a page to the list of unusable pages and
> used it instead of the free_page() here.
Thanks.
> > > + p = pbe;
> > > + pbe += PB_PAGE_SK
Hi,
On Monday, 7 of February 2005 17:23, Pavel Machek wrote:
> Hi!
>
> > The (updated) patch follows.
>
> Okay, few comments...
>
>
> > Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]>
> >
> > diff -Nru linux-2.6.11-rc3-mm1-orig/arch/i386/power/swsusp.S
> > linux-2.6.11-rc3-mm1/arch/i386
Hi!
> The (updated) patch follows.
Okay, few comments...
> Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]>
>
> diff -Nru linux-2.6.11-rc3-mm1-orig/arch/i386/power/swsusp.S
> linux-2.6.11-rc3-mm1/arch/i386/power/swsusp.S
> --- linux-2.6.11-rc3-mm1-orig/arch/i386/power/swsusp.S2004
Hi,
On Monday, 7 of February 2005 15:27, Pavel Machek wrote:
> Hi!
>
> > > The following patch is (yet) an(other) attempt to eliminate the need for
> > > using higher
> > > order memory allocations on resume. It accomplishes this by replacing
> > > the array
> > > of page backup entries with a
Hi!
> > The following patch is (yet) an(other) attempt to eliminate the need for
> > using higher
> > order memory allocations on resume. It accomplishes this by replacing the
> > array
> > of page backup entries with a list, so it is only necessary to allocate
> > individual
> > memory pages.
Hi,
On Monday, 31 of January 2005 00:19, Rafael J. Wysocki wrote:
> Hi,
>
> The following patch is (yet) an(other) attempt to eliminate the need for
> using higher
> order memory allocations on resume. It accomplishes this by replacing the
> array
> of page backup entries with a list, so it is
11 matches
Mail list logo
