Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers

2007-05-31 Thread Nigel Cunningham
Hi. On Thu, 2007-05-31 at 22:02 +0200, Rafael J. Wysocki wrote: > Hi, > > On Thursday, 31 May 2007 16:23, Pavel Machek wrote: > > Hi! > > > > > > > I'll post revised patches in a new thread. > > > > > > > > I haven't been giving this much attention, so forgive me if I'm about to > > > > ask a s

Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers

2007-05-31 Thread Rafael J. Wysocki
Hi, On Thursday, 31 May 2007 16:23, Pavel Machek wrote: > Hi! > > > > > I'll post revised patches in a new thread. > > > > > > I haven't been giving this much attention, so forgive me if I'm about to > > > ask a silly question... which notifiers would you see the avenrun > > > saving/restoring u

Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers

2007-05-31 Thread Pavel Machek
Hi! > > > I'll post revised patches in a new thread. > > > > I haven't been giving this much attention, so forgive me if I'm about to > > ask a silly question... which notifiers would you see the avenrun > > saving/restoring using? > > I'm not sure what you mean. Could you please clarify? Reme

Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers

2007-05-30 Thread Rafael J. Wysocki
Hi, On Thursday, 31 May 2007 00:24, Nigel Cunningham wrote: > Hi. > > On Wed, 2007-05-30 at 23:11 +0200, Rafael J. Wysocki wrote: > > On Wednesday, 30 May 2007 22:44, Rafael J. Wysocki wrote: > > > Hi, > > > > > > On Wednesday, 30 May 2007 17:37, Pavel Machek wrote: > > > > Hi! > > > > > > > >

Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers

2007-05-30 Thread Rafael J. Wysocki
On Thursday, 31 May 2007 00:29, Pavel Machek wrote: > Hi! > > > > I think the rule should be: If you need to do something _before_ tasks are > > > frozen, do it in PM_PRE_FREEZE, but if you can do that after the tasks > > > have > > > been frozen, do it on PM_HIBERNATION_PREPARE (or PM_SUSPEND_PR

Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers

2007-05-30 Thread Pavel Machek
Hi! > > I think the rule should be: If you need to do something _before_ tasks are > > frozen, do it in PM_PRE_FREEZE, but if you can do that after the tasks have > > been frozen, do it on PM_HIBERNATION_PREPARE (or PM_SUSPEND_PREPARE in the > > suspend case). > > OTOH, having considered it for a

Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers

2007-05-30 Thread Nigel Cunningham
Hi. On Wed, 2007-05-30 at 23:11 +0200, Rafael J. Wysocki wrote: > On Wednesday, 30 May 2007 22:44, Rafael J. Wysocki wrote: > > Hi, > > > > On Wednesday, 30 May 2007 17:37, Pavel Machek wrote: > > > Hi! > > > > > > > +Suspend notifiers > > > > + (C) 2007 Rafael J. Wysocki <[EMAIL PROTECTED

Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers

2007-05-30 Thread Rafael J. Wysocki
On Wednesday, 30 May 2007 22:44, Rafael J. Wysocki wrote: > Hi, > > On Wednesday, 30 May 2007 17:37, Pavel Machek wrote: > > Hi! > > > > > +Suspend notifiers > > > + (C) 2007 Rafael J. Wysocki <[EMAIL PROTECTED]>, GPL > > > + > > > +There are some operations that device drivers may want to carry

Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers

2007-05-30 Thread Rafael J. Wysocki
Hi, On Wednesday, 30 May 2007 17:37, Pavel Machek wrote: > Hi! > > > +Suspend notifiers > > + (C) 2007 Rafael J. Wysocki <[EMAIL PROTECTED]>, GPL > > + > > +There are some operations that device drivers may want to carry out in > > their > > +.suspend() routines, but shouldn't, because they ca

Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers

2007-05-30 Thread Pavel Machek
Hi! > +Suspend notifiers > + (C) 2007 Rafael J. Wysocki <[EMAIL PROTECTED]>, GPL > + > +There are some operations that device drivers may want to carry out in their > +.suspend() routines, but shouldn't, because they can cause the hibernation or > +suspend to fail. For example, a driver may wa

Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers

2007-05-29 Thread Rafael J. Wysocki
On Monday, 28 May 2007 17:56, Alan Stern wrote: > On Sun, 27 May 2007, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > > > Make it possible to register hibernation and suspend notifiers, so that > > subsystems can perform hibernation-related or suspend-related opera

Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers

2007-05-28 Thread Rafael J. Wysocki
On Monday, 28 May 2007 17:56, Alan Stern wrote: > On Sun, 27 May 2007, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > > > Make it possible to register hibernation and suspend notifiers, so that > > subsystems can perform hibernation-related or suspend-related opera

Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers

2007-05-28 Thread Rafael J. Wysocki
On Monday, 28 May 2007 15:12, Pavel Machek wrote: > Hi! > > > Make it possible to register hibernation and suspend notifiers, so that > > subsystems can perform hibernation-related or suspend-related operations > > that > > should not be carried out by device drivers' .suspend() and > > .resume()

Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers

2007-05-28 Thread Alan Stern
On Sun, 27 May 2007, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > Make it possible to register hibernation and suspend notifiers, so that > subsystems can perform hibernation-related or suspend-related operations that > should not be carried out by device drivers' .s

Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers

2007-05-28 Thread Pavel Machek
Hi! > Make it possible to register hibernation and suspend notifiers, so that > subsystems can perform hibernation-related or suspend-related operations that > should not be carried out by device drivers' .suspend() and > .resume() routines. I believe it adds _way_ too many notifiers. > +PM_PRE_

Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers

2007-05-28 Thread Nigel Cunningham
Hi. Quick read only, but it looks good to me. Nigel signature.asc Description: This is a digitally signed message part

[RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers

2007-05-27 Thread Rafael J. Wysocki
From: Rafael J. Wysocki <[EMAIL PROTECTED]> Make it possible to register hibernation and suspend notifiers, so that subsystems can perform hibernation-related or suspend-related operations that should not be carried out by device drivers' .suspend() and .resume() routines. Signed-off-by: Rafael J