Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Fri, Jun 3, 2016 at 5:00 AM, Peter Zijlstra wrote: > On Fri, Jun 03, 2016 at 10:04:07AM +0200, Ingo Molnar wrote: >> >> btw., for some reason I don't have the mails from Jason in my mbox, perhaps >> GMail >> spam filtering ate it? > > Linus has been complaining about a

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Fri, Jun 3, 2016 at 5:00 AM, Peter Zijlstra wrote: > On Fri, Jun 03, 2016 at 10:04:07AM +0200, Ingo Molnar wrote: >> >> btw., for some reason I don't have the mails from Jason in my mbox, perhaps >> GMail >> spam filtering ate it? > > Linus has been complaining about a lot of lost email due

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Sat, 2016-06-04 at 00:36 +0200, Peter Zijlstra wrote: > On Fri, Jun 03, 2016 at 11:09:54AM -0700, Jason Low wrote: > > --- a/arch/alpha/include/asm/rwsem.h > > +++ b/arch/alpha/include/asm/rwsem.h > > @@ -25,8 +25,8 @@ static inline void __down_read(struct rw_semaphore *sem) > > { > > long

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Sat, 2016-06-04 at 00:36 +0200, Peter Zijlstra wrote: > On Fri, Jun 03, 2016 at 11:09:54AM -0700, Jason Low wrote: > > --- a/arch/alpha/include/asm/rwsem.h > > +++ b/arch/alpha/include/asm/rwsem.h > > @@ -25,8 +25,8 @@ static inline void __down_read(struct rw_semaphore *sem) > > { > > long

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Fri, Jun 03, 2016 at 11:09:54AM -0700, Jason Low wrote: > --- a/arch/alpha/include/asm/rwsem.h > +++ b/arch/alpha/include/asm/rwsem.h > @@ -25,8 +25,8 @@ static inline void __down_read(struct rw_semaphore *sem) > { > long oldcount; > #ifndef CONFIG_SMP > - oldcount =

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Fri, Jun 03, 2016 at 11:09:54AM -0700, Jason Low wrote: > --- a/arch/alpha/include/asm/rwsem.h > +++ b/arch/alpha/include/asm/rwsem.h > @@ -25,8 +25,8 @@ static inline void __down_read(struct rw_semaphore *sem) > { > long oldcount; > #ifndef CONFIG_SMP > - oldcount =

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Fri, Jun 03, 2016 at 11:09:54AM -0700, Jason Low wrote: > arch/alpha/include/asm/rwsem.h | 26 +- > arch/ia64/include/asm/rwsem.h | 20 ++-- So I was looking at rm arch/*/include/asm/rwsem.h :-) Because at the end of the day you're reimplementing

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Fri, Jun 03, 2016 at 11:09:54AM -0700, Jason Low wrote: > arch/alpha/include/asm/rwsem.h | 26 +- > arch/ia64/include/asm/rwsem.h | 20 ++-- So I was looking at rm arch/*/include/asm/rwsem.h :-) Because at the end of the day you're reimplementing

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Fri, 2016-06-03 at 10:04 +0200, Ingo Molnar wrote: > * Peter Zijlstra wrote: > > > On Mon, May 16, 2016 at 06:12:25PM -0700, Linus Torvalds wrote: > > > On Mon, May 16, 2016 at 5:37 PM, Jason Low wrote: > > > > > > > > This rest of the series

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Fri, 2016-06-03 at 10:04 +0200, Ingo Molnar wrote: > * Peter Zijlstra wrote: > > > On Mon, May 16, 2016 at 06:12:25PM -0700, Linus Torvalds wrote: > > > On Mon, May 16, 2016 at 5:37 PM, Jason Low wrote: > > > > > > > > This rest of the series converts the rwsem count variable to an > > > >

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Fri, Jun 03, 2016 at 02:00:42PM +0200, Peter Zijlstra wrote: > On Fri, Jun 03, 2016 at 10:04:07AM +0200, Ingo Molnar wrote: > > So I tried to pick up this series, and it broke the Alpha and IA64 builds: > > > > /home/mingo/tip/arch/ia64/include/asm/rwsem.h: In function '___down_write': > >

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Fri, Jun 03, 2016 at 02:00:42PM +0200, Peter Zijlstra wrote: > On Fri, Jun 03, 2016 at 10:04:07AM +0200, Ingo Molnar wrote: > > So I tried to pick up this series, and it broke the Alpha and IA64 builds: > > > > /home/mingo/tip/arch/ia64/include/asm/rwsem.h: In function '___down_write': > >

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Fri, Jun 03, 2016 at 10:04:07AM +0200, Ingo Molnar wrote: > So I tried to pick up this series, and it broke the Alpha and IA64 builds: > > /home/mingo/tip/arch/ia64/include/asm/rwsem.h: In function '___down_write': > /home/mingo/tip/arch/ia64/include/asm/rwsem.h:58:7: error: incompatible types

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Fri, Jun 03, 2016 at 10:04:07AM +0200, Ingo Molnar wrote: > So I tried to pick up this series, and it broke the Alpha and IA64 builds: > > /home/mingo/tip/arch/ia64/include/asm/rwsem.h: In function '___down_write': > /home/mingo/tip/arch/ia64/include/asm/rwsem.h:58:7: error: incompatible types

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

* Peter Zijlstra wrote: > On Mon, May 16, 2016 at 06:12:25PM -0700, Linus Torvalds wrote: > > On Mon, May 16, 2016 at 5:37 PM, Jason Low wrote: > > > > > > This rest of the series converts the rwsem count variable to an > > > atomic_long_t > > > since

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

* Peter Zijlstra wrote: > On Mon, May 16, 2016 at 06:12:25PM -0700, Linus Torvalds wrote: > > On Mon, May 16, 2016 at 5:37 PM, Jason Low wrote: > > > > > > This rest of the series converts the rwsem count variable to an > > > atomic_long_t > > > since it is used it as an atomic variable. This

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Tue, 17 May 2016, Peter Zijlstra wrote: Subject: locking,rwsem: Remove rwsem_atomic_add() and rwsem_atomic_update() From: Jason Low Date: Mon, 16 May 2016 17:38:02 -0700 The rwsem-xadd count has been converted to an atomic variable and the rwsem code now directly uses

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Tue, 17 May 2016, Peter Zijlstra wrote: Subject: locking,rwsem: Remove rwsem_atomic_add() and rwsem_atomic_update() From: Jason Low Date: Mon, 16 May 2016 17:38:02 -0700 The rwsem-xadd count has been converted to an atomic variable and the rwsem code now directly uses atomic_long_add() and

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Tue, 2016-05-17 at 13:09 +0200, Peter Zijlstra wrote: > On Mon, May 16, 2016 at 06:12:25PM -0700, Linus Torvalds wrote: > > On Mon, May 16, 2016 at 5:37 PM, Jason Low wrote: > > > > > > This rest of the series converts the rwsem count variable to an > > > atomic_long_t > >

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Tue, 2016-05-17 at 13:09 +0200, Peter Zijlstra wrote: > On Mon, May 16, 2016 at 06:12:25PM -0700, Linus Torvalds wrote: > > On Mon, May 16, 2016 at 5:37 PM, Jason Low wrote: > > > > > > This rest of the series converts the rwsem count variable to an > > > atomic_long_t > > > since it is used

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Mon, May 16, 2016 at 06:12:25PM -0700, Linus Torvalds wrote: > On Mon, May 16, 2016 at 5:37 PM, Jason Low wrote: > > > > This rest of the series converts the rwsem count variable to an > > atomic_long_t > > since it is used it as an atomic variable. This allows us to also

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Mon, May 16, 2016 at 06:12:25PM -0700, Linus Torvalds wrote: > On Mon, May 16, 2016 at 5:37 PM, Jason Low wrote: > > > > This rest of the series converts the rwsem count variable to an > > atomic_long_t > > since it is used it as an atomic variable. This allows us to also remove > > the

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Mon, May 16, 2016 at 5:37 PM, Jason Low wrote: > > This rest of the series converts the rwsem count variable to an atomic_long_t > since it is used it as an atomic variable. This allows us to also remove > the rwsem_atomic_{add,update} abstraction and reduce 100+ lines of

Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

On Mon, May 16, 2016 at 5:37 PM, Jason Low wrote: > > This rest of the series converts the rwsem count variable to an atomic_long_t > since it is used it as an atomic variable. This allows us to also remove > the rwsem_atomic_{add,update} abstraction and reduce 100+ lines of code. I would

[RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

The first patch contains an optimization for acquiring the rwsem write lock in the slowpath. This rest of the series converts the rwsem count variable to an atomic_long_t since it is used it as an atomic variable. This allows us to also remove the rwsem_atomic_{add,update} abstraction and reduce

[RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t

The first patch contains an optimization for acquiring the rwsem write lock in the slowpath. This rest of the series converts the rwsem count variable to an atomic_long_t since it is used it as an atomic variable. This allows us to also remove the rwsem_atomic_{add,update} abstraction and reduce