Re: [RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-22 Thread David Howells
J. Bruce Fields wrote: > > J. Bruce Fields wrote: > > > So, I'm still confused: there must be some case where we know fscache > > > actually works reliably and doesn't corrupt your data, right? > > > > Using ext2/3, for example. I don't know under what circumstances xfs, ext4 > > and btrfs mig

Re: [RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-22 Thread J. Bruce Fields
On Thu, Jan 21, 2021 at 08:08:24PM +, David Howells wrote: > J. Bruce Fields wrote: > > So, I'm still confused: there must be some case where we know fscache > > actually works reliably and doesn't corrupt your data, right? > > Using ext2/3, for example. I don't know under what circumstances

Re: [RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-22 Thread Christoph Hellwig
On Thu, Jan 21, 2021 at 06:55:13PM +, David Howells wrote: > > Is it that those "bridging" blocks only show up in certain corner cases > > that users can arrange to avoid? Or that it's OK as long as you use > > certain specific file systems whose behavior goes beyond what's > > technically req

Re: [RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-21 Thread David Howells
J. Bruce Fields wrote: > > J. Bruce Fields wrote: > > > > > > Fixing this requires a much bigger overhaul of cachefiles than this > > > > patchset > > > > performs. > > > > > > That sounds like "sometimes you may get file corruption and there's > > > nothing you can do about it". But I know

Re: [RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-21 Thread David Howells
J. Bruce Fields wrote: > > Fixing this requires a much bigger overhaul of cachefiles than this patchset > > performs. > > That sounds like "sometimes you may get file corruption and there's > nothing you can do about it". But I know people actually use fscache, > so it must be reliable at least

Re: [RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-21 Thread J. Bruce Fields
On Thu, Jan 21, 2021 at 06:55:13PM +, David Howells wrote: > J. Bruce Fields wrote: > > > > Fixing this requires a much bigger overhaul of cachefiles than this > > > patchset > > > performs. > > > > That sounds like "sometimes you may get file corruption and there's > > nothing you can do a

Re: [RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-21 Thread J. Bruce Fields
On Thu, Jan 21, 2021 at 05:02:57PM +, David Howells wrote: > J. Bruce Fields wrote: > > > On Wed, Jan 20, 2021 at 10:21:24PM +, David Howells wrote: > > > Note that this uses SEEK_HOLE/SEEK_DATA to locate the data available > > > to be read from the cache. Whilst this is an imp

Re: [RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-21 Thread David Howells
J. Bruce Fields wrote: > On Wed, Jan 20, 2021 at 10:21:24PM +, David Howells wrote: > > Note that this uses SEEK_HOLE/SEEK_DATA to locate the data available > > to be read from the cache. Whilst this is an improvement from the > > bmap interface, it still has a problem with re

Re: [RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-21 Thread J. Bruce Fields
On Wed, Jan 20, 2021 at 10:21:24PM +, David Howells wrote: > Note that this uses SEEK_HOLE/SEEK_DATA to locate the data available > to be read from the cache. Whilst this is an improvement from the > bmap interface, it still has a problem with regard to a modern > extent-ba

[RFC][PATCH 00/25] Network fs helper library & fscache kiocb API

2021-01-20 Thread David Howells
Here's a set of patches to do two things: (1) Add a helper library to handle the new VM readahead interface. This is intended to be used unconditionally by the filesystem (whether or not caching is enabled) and provides a common framework for doing caching, transparent huge page