Re: [RFC][PATCH 05/13] mm/numa: automatically generate node migration order

2021-02-03 Thread Yang Shi
On Tue, Feb 2, 2021 at 4:43 PM Dave Hansen wrote: > > On 2/2/21 9:46 AM, Yang Shi wrote: > > On Mon, Feb 1, 2021 at 11:13 AM Dave Hansen wrote: > >> On 1/29/21 12:46 PM, Yang Shi wrote: > >> ... > int next_demotion_node(int node) > { > - return node_demotion[node]; >

Re: [RFC][PATCH 05/13] mm/numa: automatically generate node migration order

2021-02-02 Thread Dave Hansen
On 2/2/21 9:46 AM, Yang Shi wrote: > On Mon, Feb 1, 2021 at 11:13 AM Dave Hansen wrote: >> On 1/29/21 12:46 PM, Yang Shi wrote: >> ... int next_demotion_node(int node) { - return node_demotion[node]; + /* +* node_demotion[] is updated without

Re: [RFC][PATCH 05/13] mm/numa: automatically generate node migration order

2021-02-02 Thread Yang Shi
On Mon, Feb 1, 2021 at 11:13 AM Dave Hansen wrote: > > On 1/29/21 12:46 PM, Yang Shi wrote: > ... > >> int next_demotion_node(int node) > >> { > >> - return node_demotion[node]; > >> + /* > >> +* node_demotion[] is updated without excluding > >> +* this function from

Re: [RFC][PATCH 05/13] mm/numa: automatically generate node migration order

2021-02-02 Thread Oscar Salvador
On Mon, Feb 01, 2021 at 11:13:14AM -0800, Dave Hansen wrote: > Sure. Were you thinking of a code comment, or enhanced changelog? > > Let's say there's a system with two sockets each with the same three > classes of memory: fast, medium and slow. Each memory class is placed > in its own NUMA

Re: [RFC][PATCH 05/13] mm/numa: automatically generate node migration order

2021-02-01 Thread Dave Hansen
On 1/29/21 12:46 PM, Yang Shi wrote: ... >> int next_demotion_node(int node) >> { >> - return node_demotion[node]; >> + /* >> +* node_demotion[] is updated without excluding >> +* this function from running. READ_ONCE() avoids >> +* reading multiple,

Re: [RFC][PATCH 05/13] mm/numa: automatically generate node migration order

2021-01-29 Thread Yang Shi
On Mon, Jan 25, 2021 at 4:41 PM Dave Hansen wrote: > > > From: Dave Hansen > > When memory fills up on a node, memory contents can be > automatically migrated to another node. The biggest problems are > knowing when to migrate and to where the migration should be > targeted. > > The most

[RFC][PATCH 05/13] mm/numa: automatically generate node migration order

2021-01-25 Thread Dave Hansen
From: Dave Hansen When memory fills up on a node, memory contents can be automatically migrated to another node. The biggest problems are knowing when to migrate and to where the migration should be targeted. The most straightforward way to generate the "to where" list would be to follow the