Re: [RFC][PATCH 06/14] fgraph: Move function graph specific code into fgraph.c

2018-11-25 Thread Masami Hiramatsu
On Thu, 22 Nov 2018 22:11:33 -0800 Joel Fernandes wrote: > On Wed, Nov 21, 2018 at 08:27:14PM -0500, Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > > > To make the function graph infrastructure more managable, the code needs to > > be in its own file (fgraph.c). Move the code tha

Re: [RFC][PATCH 06/14] fgraph: Move function graph specific code into fgraph.c

2018-11-23 Thread Joel Fernandes
On Fri, Nov 23, 2018 at 01:11:38PM -0500, Steven Rostedt wrote: > On Fri, 23 Nov 2018 12:58:34 -0500 > Steven Rostedt wrote: > > > I think the better answer is to move it into trace_functions_graph.c. > > I take that back. I think the better answer is to not call that > function if the profiler

Re: [RFC][PATCH 06/14] fgraph: Move function graph specific code into fgraph.c

2018-11-23 Thread Steven Rostedt
On Fri, 23 Nov 2018 12:58:34 -0500 Steven Rostedt wrote: > I think the better answer is to move it into trace_functions_graph.c. I take that back. I think the better answer is to not call that function if the profiler is not set, nor have that option even available. Because it has no meaning wit

Re: [RFC][PATCH 06/14] fgraph: Move function graph specific code into fgraph.c

2018-11-23 Thread Steven Rostedt
On Thu, 22 Nov 2018 22:11:33 -0800 Joel Fernandes wrote: > On Wed, Nov 21, 2018 at 08:27:14PM -0500, Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > > > To make the function graph infrastructure more managable, the code needs to > > be in its own file (fgraph.c). Move the code tha

Re: [RFC][PATCH 06/14] fgraph: Move function graph specific code into fgraph.c

2018-11-22 Thread Joel Fernandes
On Wed, Nov 21, 2018 at 08:27:14PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > To make the function graph infrastructure more managable, the code needs to > be in its own file (fgraph.c). Move the code that is specific for managing > the function graph infrastructure out of

[RFC][PATCH 06/14] fgraph: Move function graph specific code into fgraph.c

2018-11-21 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" To make the function graph infrastructure more managable, the code needs to be in its own file (fgraph.c). Move the code that is specific for managing the function graph infrastructure out of ftrace.c and into fgraph.c Signed-off-by: Steven Rostedt (VMware) ---