Re: [RFC][PATCH 1/2 v2] ftrace/x86: Allow for arguments to be passed in to REGS by default

2020-10-29 Thread Masami Hiramatsu
On Wed, 28 Oct 2020 11:29:16 -0400 Steven Rostedt wrote: > Hi Masami, > > Talking with Peter and Thomas on IRC, where they really don't like > passing a partial pt_regs around, got me thinking of redoing the REGS > parameter of ftrace. Kprobes is the only user that requires the full > registers

[RFC][PATCH 1/2 v2] ftrace/x86: Allow for arguments to be passed in to REGS by default

2020-10-28 Thread Steven Rostedt
>From b5f5cfc63f38415b4ca7eb4cfb8c78113bfa17e0 Mon Sep 17 00:00:00 2001 From: "Steven Rostedt (VMware)" Date: Tue, 27 Oct 2020 10:55:55 -0400 Subject: [PATCH] ftrace/x86: Allow for arguments to be passed in to REGS by default Currently, the only way to get access to the registers of a function

Re: [RFC][PATCH 1/2 v2] ftrace/x86: Allow for arguments to be passed in to REGS by default

2020-10-28 Thread Steven Rostedt
Hi Masami, Talking with Peter and Thomas on IRC, where they really don't like passing a partial pt_regs around, got me thinking of redoing the REGS parameter of ftrace. Kprobes is the only user that requires the full registers being saved, and that's only because some kprobe user might want them.

Re: [RFC][PATCH 1/2 v2] ftrace/x86: Allow for arguments to be passed in to REGS by default

2020-10-28 Thread Steven Rostedt
On Wed, 28 Oct 2020 16:36:26 -0400 Steven Rostedt wrote: > Here's a proof of concept patch. It passes all the kprobe self tests in > the ftracetest suite. This is just a proof of concept, and I already > know of a couple of subtle bugs that are easy to fix. But this shows > the general idea.

Re: [RFC][PATCH 1/2 v2] ftrace/x86: Allow for arguments to be passed in to REGS by default

2020-10-28 Thread Steven Rostedt
On Wed, 28 Oct 2020 11:29:16 -0400 Steven Rostedt wrote: > Then kprobes could just create its own pt_regs, fill in all the data > from ftrace_regs and then fill the rest with zeros or possibly whatever > the values currently are (does it really matter what those registers > are?), including