Re: [RFC][PATCH 1/3] objtool: Clean up elf_write() condition

2020-06-16 Thread Peter Zijlstra
On Mon, Jun 15, 2020 at 08:44:11PM +0200, Peter Zijlstra wrote: > On Mon, Jun 15, 2020 at 11:34:48AM -0700, Matt Helsley wrote: > > On Fri, Jun 12, 2020 at 04:30:35PM +0200, Peter Zijlstra wrote: > > > With there being multiple ways to change the ELF data, let's more > > > concisely track

Re: [RFC][PATCH 1/3] objtool: Clean up elf_write() condition

2020-06-15 Thread Peter Zijlstra
On Mon, Jun 15, 2020 at 11:34:48AM -0700, Matt Helsley wrote: > On Fri, Jun 12, 2020 at 04:30:35PM +0200, Peter Zijlstra wrote: > > With there being multiple ways to change the ELF data, let's more > > concisely track modification. > > > > Signed-off-by: Peter Zijlstra (Intel) > > Would it make

Re: [RFC][PATCH 1/3] objtool: Clean up elf_write() condition

2020-06-15 Thread Matt Helsley
On Fri, Jun 12, 2020 at 04:30:35PM +0200, Peter Zijlstra wrote: > With there being multiple ways to change the ELF data, let's more > concisely track modification. > > Signed-off-by: Peter Zijlstra (Intel) Would it make sense to set the relocation section's "changed" flag in addition to the elf

[RFC][PATCH 1/3] objtool: Clean up elf_write() condition

2020-06-12 Thread Peter Zijlstra
With there being multiple ways to change the ELF data, let's more concisely track modification. Signed-off-by: Peter Zijlstra (Intel) --- tools/objtool/check.c |2 ++ tools/objtool/elf.c |8 +++- tools/objtool/elf.h |3 ++- 3 files changed, 11 insertions(+), 2 deletions(-)