Re: [RFC][PATCH 1/5] mips/atomic: Fix cmpxchg64 barriers

On Wed, Apr 24, 2019 at 09:00:25PM +, Paul Burton wrote: > Hi Peter, > > On Wed, Apr 24, 2019 at 02:36:57PM +0200, Peter Zijlstra wrote: > > There were no memory barriers on cmpxchg64() _at_all_. Fix this. > > This does looks problematic, but it's worth noting that this code path > is only ap

Re: [RFC][PATCH 1/5] mips/atomic: Fix cmpxchg64 barriers

Hi Peter, On Wed, Apr 24, 2019 at 02:36:57PM +0200, Peter Zijlstra wrote: > There were no memory barriers on cmpxchg64() _at_all_. Fix this. This does looks problematic, but it's worth noting that this code path is only applicable to 32b kernels running on 64b CPUs which is pretty rare. The commi

[RFC][PATCH 1/5] mips/atomic: Fix cmpxchg64 barriers

There were no memory barriers on cmpxchg64() _at_all_. Fix this. Cc: Paul Burton Signed-off-by: Peter Zijlstra (Intel) --- arch/mips/include/asm/cmpxchg.h |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/arch/mips/include/asm/cmpxchg.h +++ b/arch/mips/include/asm/cmpxchg.h