Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-09-07 Thread Greg KH
On Sat, Sep 03, 2005 at 09:54:45PM -0700, Joel Becker wrote: > Finally, assuming that the sysfs_dirent/configfs_dirent > arrangement is pretty fleshed out, I think that perhaps this backing > store could be joined. Again, no more magic could be added, and it > would have to handle the sysfs

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-09-07 Thread Greg KH
On Sat, Sep 03, 2005 at 09:54:45PM -0700, Joel Becker wrote: Finally, assuming that the sysfs_dirent/configfs_dirent arrangement is pretty fleshed out, I think that perhaps this backing store could be joined. Again, no more magic could be added, and it would have to handle the sysfs and

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-09-03 Thread Joel Becker
On Sat, Sep 03, 2005 at 09:41:36PM -0700, Joel Becker wrote: > On Sat, Sep 03, 2005 at 09:12:24PM -0700, Joel Becker wrote: > > On Tue, Aug 30, 2005 at 04:28:46PM -0700, Andrew Morton wrote: > > > Sure, but all that copying-and-pasting really sucks. I'm sure there's > > > some > > > way of

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-09-03 Thread Joel Becker
On Sat, Sep 03, 2005 at 09:12:24PM -0700, Joel Becker wrote: > On Tue, Aug 30, 2005 at 04:28:46PM -0700, Andrew Morton wrote: > > Sure, but all that copying-and-pasting really sucks. I'm sure there's some > > way of providing the slightly different semantics from the same codebase? The

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-09-03 Thread Joel Becker
On Tue, Aug 30, 2005 at 04:28:46PM -0700, Andrew Morton wrote: > Sure, but all that copying-and-pasting really sucks. I'm sure there's some > way of providing the slightly different semantics from the same codebase? What about the backing store? Specifically, sysfs_dirent vs

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-09-03 Thread Joel Becker
On Tue, Aug 30, 2005 at 04:28:46PM -0700, Andrew Morton wrote: > Sure, but all that copying-and-pasting really sucks. I'm sure there's some > way of providing the slightly different semantics from the same codebase? First, let's look at sharing the primary structures. [kobject vs

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-09-03 Thread Joel Becker
On Tue, Aug 30, 2005 at 04:28:46PM -0700, Andrew Morton wrote: Sure, but all that copying-and-pasting really sucks. I'm sure there's some way of providing the slightly different semantics from the same codebase? First, let's look at sharing the primary structures. [kobject vs

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-09-03 Thread Joel Becker
On Tue, Aug 30, 2005 at 04:28:46PM -0700, Andrew Morton wrote: Sure, but all that copying-and-pasting really sucks. I'm sure there's some way of providing the slightly different semantics from the same codebase? What about the backing store? Specifically, sysfs_dirent vs

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-09-03 Thread Joel Becker
On Sat, Sep 03, 2005 at 09:12:24PM -0700, Joel Becker wrote: On Tue, Aug 30, 2005 at 04:28:46PM -0700, Andrew Morton wrote: Sure, but all that copying-and-pasting really sucks. I'm sure there's some way of providing the slightly different semantics from the same codebase? The final

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-09-03 Thread Joel Becker
On Sat, Sep 03, 2005 at 09:41:36PM -0700, Joel Becker wrote: On Sat, Sep 03, 2005 at 09:12:24PM -0700, Joel Becker wrote: On Tue, Aug 30, 2005 at 04:28:46PM -0700, Andrew Morton wrote: Sure, but all that copying-and-pasting really sucks. I'm sure there's some way of providing the

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-08-30 Thread Joel Becker
On Tue, Aug 30, 2005 at 04:28:46PM -0700, Andrew Morton wrote: > Joel Becker <[EMAIL PROTECTED]> wrote: > > The fact that sysfs and configfs have similar backing stores > > does not make them the same thing. > > > > Sure, but all that copying-and-pasting really sucks. I'm sure there's some

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-08-30 Thread Daniel Phillips
On Wednesday 31 August 2005 09:34, [EMAIL PROTECTED] wrote: > On Tue, Aug 30, 2005 at 04:28:46PM -0700, Andrew Morton wrote: > > Sure, but all that copying-and-pasting really sucks. I'm sure there's > > some way of providing the slightly different semantics from the same > > codebase? > > Careful

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-08-30 Thread Daniel Phillips
On Wednesday 31 August 2005 09:28, Andrew Morton wrote: > Joel Becker <[EMAIL PROTECTED]> wrote: > > On Wed, Aug 31, 2005 at 08:54:39AM +1000, Daniel Phillips wrote: > > > But it would be stupid to forbid users from creating directories in > > > sysfs or to forbid kernel modules from directly

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-08-30 Thread Daniel Phillips
On Wednesday 31 August 2005 09:25, Daniel Phillips wrote: > On Wednesday 31 August 2005 09:13, Joel Becker wrote: > > On Wed, Aug 31, 2005 at 08:54:39AM +1000, Daniel Phillips wrote: > > > But it would be stupid to forbid users from creating directories in > > > sysfs or to forbid kernel modules

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-08-30 Thread viro
On Tue, Aug 30, 2005 at 04:28:46PM -0700, Andrew Morton wrote: > Sure, but all that copying-and-pasting really sucks. I'm sure there's some > way of providing the slightly different semantics from the same codebase? Careful - you've almost reinvented the concept of library, which would violate

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-08-30 Thread Andrew Morton
Joel Becker <[EMAIL PROTECTED]> wrote: > > On Wed, Aug 31, 2005 at 08:54:39AM +1000, Daniel Phillips wrote: > > But it would be stupid to forbid users from creating directories in sysfs > > or > > to forbid kernel modules from directly tweaking a configfs namespace. Why > > should the kernel

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-08-30 Thread Daniel Phillips
On Wednesday 31 August 2005 09:13, Joel Becker wrote: > On Wed, Aug 31, 2005 at 08:54:39AM +1000, Daniel Phillips wrote: > > But it would be stupid to forbid users from creating directories in sysfs > > or to forbid kernel modules from directly tweaking a configfs namespace. > > Why should the

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-08-30 Thread Joel Becker
On Wed, Aug 31, 2005 at 08:54:39AM +1000, Daniel Phillips wrote: > But it would be stupid to forbid users from creating directories in sysfs or > to forbid kernel modules from directly tweaking a configfs namespace. Why > should the kernel not be able to add objects to a directory a user

[RFC][PATCH 1 of 4] Configfs is really sysfs

2005-08-30 Thread Daniel Phillips
Hi Andrew, Configfs blithely ingests kobject.h and kobject.c into itself, just changing the names. Furthermore, more than half of configfs is copied verbatim from sysfs, the only difference being the name changes. After undoing the name changes and adding a few new fields to kobject

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-08-30 Thread Joel Becker
On Wed, Aug 31, 2005 at 08:54:39AM +1000, Daniel Phillips wrote: But it would be stupid to forbid users from creating directories in sysfs or to forbid kernel modules from directly tweaking a configfs namespace. Why should the kernel not be able to add objects to a directory a user created?

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-08-30 Thread Daniel Phillips
On Wednesday 31 August 2005 09:13, Joel Becker wrote: On Wed, Aug 31, 2005 at 08:54:39AM +1000, Daniel Phillips wrote: But it would be stupid to forbid users from creating directories in sysfs or to forbid kernel modules from directly tweaking a configfs namespace. Why should the kernel

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-08-30 Thread Andrew Morton
Joel Becker [EMAIL PROTECTED] wrote: On Wed, Aug 31, 2005 at 08:54:39AM +1000, Daniel Phillips wrote: But it would be stupid to forbid users from creating directories in sysfs or to forbid kernel modules from directly tweaking a configfs namespace. Why should the kernel not be able

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-08-30 Thread viro
On Tue, Aug 30, 2005 at 04:28:46PM -0700, Andrew Morton wrote: Sure, but all that copying-and-pasting really sucks. I'm sure there's some way of providing the slightly different semantics from the same codebase? Careful - you've almost reinvented the concept of library, which would violate any

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-08-30 Thread Daniel Phillips
On Wednesday 31 August 2005 09:25, Daniel Phillips wrote: On Wednesday 31 August 2005 09:13, Joel Becker wrote: On Wed, Aug 31, 2005 at 08:54:39AM +1000, Daniel Phillips wrote: But it would be stupid to forbid users from creating directories in sysfs or to forbid kernel modules from

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-08-30 Thread Daniel Phillips
On Wednesday 31 August 2005 09:28, Andrew Morton wrote: Joel Becker [EMAIL PROTECTED] wrote: On Wed, Aug 31, 2005 at 08:54:39AM +1000, Daniel Phillips wrote: But it would be stupid to forbid users from creating directories in sysfs or to forbid kernel modules from directly tweaking a

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-08-30 Thread Daniel Phillips
On Wednesday 31 August 2005 09:34, [EMAIL PROTECTED] wrote: On Tue, Aug 30, 2005 at 04:28:46PM -0700, Andrew Morton wrote: Sure, but all that copying-and-pasting really sucks. I'm sure there's some way of providing the slightly different semantics from the same codebase? Careful - you've

Re: [RFC][PATCH 1 of 4] Configfs is really sysfs

2005-08-30 Thread Joel Becker
On Tue, Aug 30, 2005 at 04:28:46PM -0700, Andrew Morton wrote: Joel Becker [EMAIL PROTECTED] wrote: The fact that sysfs and configfs have similar backing stores does not make them the same thing. Sure, but all that copying-and-pasting really sucks. I'm sure there's some way of