Re: [RFC][PATCH 15/42] lift fput() on late failures into path_openat()

2018-07-10 Thread Amir Goldstein
On Wed, Jul 11, 2018 at 5:21 AM, Al Viro wrote: [...] > @@ -3407,8 +3407,6 @@ static int do_last(struct nameidata *nd, > if (!error && will_truncate) > error = handle_truncate(file); > out: > - if (unlikely(error) && (*opened & FILE_OPENED)) > - fput(fi

[RFC][PATCH 15/42] lift fput() on late failures into path_openat()

2018-07-10 Thread Al Viro
From: Al Viro Signed-off-by: Al Viro --- fs/namei.c | 28 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 3d4e20a1c756..5a79bd170410 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3407,8 +3407,6 @@ static int do_last(struc